Skip to content

TEZ-4270: HeartbeatHandlerBase Does Not Need Stop Condition #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abstractdog merged 2 commits into from
Dec 26, 2021
Merged

TEZ-4270: HeartbeatHandlerBase Does Not Need Stop Condition #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ecfc5b
TEZ-4270: HeartbeatHandlerBase Does Not Need Stop Condition
belugabehr Dec 26, 2021
f6fec97
Fix tabs
belugabehr Dec 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tez-dag/src/main/java/org/apache/tez/dag/app/HeartbeatHandlerBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ public abstract class HeartbeatHandlerBase<T> extends AbstractService {
protected final AppContext appContext;

private ConcurrentMap<T, ReportTime> runningMap;
private volatile boolean stopped;

public HeartbeatHandlerBase(AppContext appContext, int expectedConcurrency, String name) {
super(name);
Expand Down Expand Up @@ -70,7 +69,6 @@ public void serviceStart() {

@Override
public void serviceStop() {
stopped = true;
if (timeOutCheckerThread != null) {
timeOutCheckerThread.interrupt();
}
Expand Down Expand Up @@ -140,7 +138,7 @@ private class PingChecker implements Runnable {

@Override
public void run() {
while (!stopped && !Thread.currentThread().isInterrupted()) {
while (!Thread.currentThread().isInterrupted()) {
Iterator<Map.Entry<T, ReportTime>> iterator =
runningMap.entrySet().iterator();

Expand All @@ -158,7 +156,7 @@ public void run() {
try {
Thread.sleep(timeOutCheckInterval);
} catch (InterruptedException e) {
break;
Thread.currentThread().interrupt();
}
}
}
Expand Down