TEZ-4214. Upgrade RoaringBitmap version to 0.7.45 #74

medb · 2020-08-02T04:37:45Z

No description provided.

jteagles · 2021-07-08T16:22:44Z

@abstractdog, do you see any issue with this version change. The last time version was upgraded was in https://issues.apache.org/jira/browse/TEZ-4040. Pig shades their version of roaringbitmap and hive doesn't use it as far as i can tell.

abstractdog · 2021-07-08T21:27:44Z

hive has only transitive dependencies on roaringbitmap, one from tez, other is from spark core, which is already 0.7.45, so it's unlikely that this change will bring confusion there from tez side
if the rebased version of this change will pass precommit tests, I would consider it safe

hadoop-yetus · 2021-07-09T02:34:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	16m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	13m 1s	master passed
+1 💚	compile	2m 16s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	2m 2s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javadoc	2m 22s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 35s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-0 ⚠️	patch	21m 43s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
-1 ❌	mvninstall	4m 7s	root in the patch failed.
+1 💚	compile	2m 17s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	2m 17s	the patch passed
+1 💚	compile	2m 2s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	2m 2s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	1m 57s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 36s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
		_ Other Tests _
+1 💚	unit	71m 29s	root in the patch passed.
+1 💚	asflicense	0m 31s	The patch does not generate ASF License warnings.
		122m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/1/artifact/out/Dockerfile
GITHUB PR	#74
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux b1eddf3f2c06 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / `b31501d`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
mvninstall	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/1/artifact/out/patch-mvninstall-root.txt
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/1/testReport/
Max. process+thread count	2089 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

medb · 2021-07-09T04:29:59Z

@abstractdog precommit tests are passing after rebase - I needed to upgrade Maven Shade Plugin version to fix the build.

abstractdog · 2021-07-09T04:33:56Z

@medb : I can see the shade plugin bump solved the shading problem
however there are 3 commits, from which I don't get this one: 00134f8
could you please squash your commits to have the final one that we can merge into master from this PR?

medb · 2021-07-09T04:53:19Z

@abstractdog this was a merge commit created by GitHub. I have squashed all changes into the single commit now.

hadoop-yetus · 2021-07-09T05:41:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	5m 0s	Maven dependency ordering for branch
+1 💚	mvninstall	8m 39s	master passed
+1 💚	compile	2m 41s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	2m 26s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javadoc	2m 32s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 55s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-0 ⚠️	patch	23m 46s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 38s	the patch passed
+1 💚	compile	2m 38s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	2m 38s	the patch passed
+1 💚	compile	2m 27s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	2m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	2m 17s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 56s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
		_ Other Tests _
+1 💚	unit	2m 47s	tez-aux-services in the patch passed.
+1 💚	unit	73m 28s	root in the patch passed.
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		116m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/2/artifact/out/Dockerfile
GITHUB PR	#74
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux 12ae5847bef9 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / `b31501d`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/2/testReport/
Max. process+thread count	1370 (vs. ulimit of 5500)
modules	C: tez-plugins/tez-aux-services . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-07-09T07:02:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	17m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	4m 57s	Maven dependency ordering for branch
+1 💚	mvninstall	8m 37s	master passed
+1 💚	compile	2m 39s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	2m 25s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javadoc	2m 30s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 56s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 37s	the patch passed
+1 💚	compile	2m 42s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	2m 42s	the patch passed
+1 💚	compile	2m 26s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	2m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	2m 18s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 57s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
		_ Other Tests _
+1 💚	unit	2m 48s	tez-aux-services in the patch passed.
+1 💚	unit	71m 7s	root in the patch passed.
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		130m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/3/artifact/out/Dockerfile
GITHUB PR	#74
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux 4179bc58c129 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / `b31501d`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/3/testReport/
Max. process+thread count	1396 (vs. ulimit of 5500)
modules	C: tez-plugins/tez-aux-services . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-74/3/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

jteagles · 2021-07-09T16:03:10Z

+1. Thanks for this change. Committing to master and branch-0.9

(cherry picked from commit 464d86d)

hadoop-yetus mentioned this pull request Apr 12, 2021

TEZ-4303: Exclude compile-time httpclient dependency from Tez #119

Merged

TEZ-4214. Upgrade RoaringBitmap version to 0.7.45

9129644

jteagles merged commit 464d86d into apache:master Jul 9, 2021

asfgit pushed a commit that referenced this pull request Jul 9, 2021

TEZ-4214. Upgrade RoaringBitmap version to 0.7.45 (#74)

dd74d68

(cherry picked from commit 464d86d)

medb deleted the TEZ-4214_RoaringBitmap branch July 9, 2021 16:31

tez-yetus mentioned this pull request Jan 31, 2022

TEZ-4380: TestSecureShuffle fails on branch-0.9 #182

Merged

This was referenced Feb 17, 2022

TEZ-4389: TestSecureShuffle fails if localhost name is different than "localhost" #191

Merged

TEZ-4388: Asynchttpclient can cause stuck TezChild processes #189

Merged

tez-yetus mentioned this pull request Mar 15, 2022

TEZ-4397 Open Tez Input splits asynchronously #195

Merged

This was referenced Apr 26, 2022

Upgrade protobuf-java version to 3.16.1 #205

Closed

Bump tmpl from 1.0.4 to 1.0.5 in /tez-ui/src/main/webapp #208

Open

tez-yetus mentioned this pull request May 25, 2022

TEZ-4417: Missing wget command in docker image #210

Merged

This was referenced Jun 16, 2022

TEZ-4429: Upgrade guava to 31.1 to fix CVE-2020-8908. #223

Merged

Bump hadoop-yarn-server-common from 3.3.1 to 3.3.2 #225

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TEZ-4214. Upgrade RoaringBitmap version to 0.7.45 #74

TEZ-4214. Upgrade RoaringBitmap version to 0.7.45 #74

Uh oh!

medb commented Aug 2, 2020

Uh oh!

jteagles commented Jul 8, 2021 •

edited

Loading

Uh oh!

abstractdog commented Jul 8, 2021

Uh oh!

hadoop-yetus commented Jul 9, 2021

Uh oh!

medb commented Jul 9, 2021

Uh oh!

abstractdog commented Jul 9, 2021

Uh oh!

medb commented Jul 9, 2021

Uh oh!

hadoop-yetus commented Jul 9, 2021

Uh oh!

hadoop-yetus commented Jul 9, 2021

Uh oh!

jteagles commented Jul 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TEZ-4214. Upgrade RoaringBitmap version to 0.7.45 #74

TEZ-4214. Upgrade RoaringBitmap version to 0.7.45 #74

Uh oh!

Conversation

medb commented Aug 2, 2020

Uh oh!

jteagles commented Jul 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abstractdog commented Jul 8, 2021

Uh oh!

hadoop-yetus commented Jul 9, 2021

Uh oh!

medb commented Jul 9, 2021

Uh oh!

abstractdog commented Jul 9, 2021

Uh oh!

medb commented Jul 9, 2021

Uh oh!

hadoop-yetus commented Jul 9, 2021

Uh oh!

hadoop-yetus commented Jul 9, 2021

Uh oh!

jteagles commented Jul 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jteagles commented Jul 8, 2021 •

edited

Loading