Skip to content

TEZ-4674: Update Dockerfile dependencies: Protobuf 3.25.5, and stable Python, npm tools #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abstractdog merged 1 commit into from
Jan 19, 2026
+17 −20
Merged

TEZ-4674: Update Dockerfile dependencies: Protobuf 3.25.5, and stable Python, npm tools #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions build-tools/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
rsync \
software-properties-common \
ssh-client \
unzip \
xz-utils \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
Expand Down Expand Up @@ -96,20 +97,16 @@ RUN add-apt-repository -y ppa:longsleep/golang-backports \
#############

######
# Install Google Protobuf 3.21.1
# Install Google Protobuf 3.25.5
######
FROM tezbase AS protobuf
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
RUN mkdir -p /opt/protobuf-src \
RUN mkdir -p /opt/protobuf \
&& curl -L -s -S \
https://github.com/protocolbuffers/protobuf/releases/download/v21.1/protobuf-java-3.21.1.tar.gz \
-o /opt/protobuf.tar.gz \
&& tar xzf /opt/protobuf.tar.gz --strip-components 1 -C /opt/protobuf-src
WORKDIR /opt/protobuf-src
RUN ./configure --prefix=/opt/protobuf \
&& make install
WORKDIR /root
RUN rm -rf /opt/protobuf-src
https://github.com/protocolbuffers/protobuf/releases/download/v25.5/protoc-25.5-linux-x86_64.zip \
Copy link
Contributor Author

@Aggarwal-Raghav Aggarwal-Raghav Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Protobuf removed Autotools (./configure and make). Wither we use CMake or Bazel to build from source or directly download the protoc which is also available on release page.
  2. URL & Versioning: The version numbering scheme changed. What was previously v3.21.x is now v25.x. The URL pattern and tarball names have changed accordingly.

Copy link
Contributor

@abstractdog abstractdog Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good, compiling protobuf from source is an overkill if there is a binary available

-o /opt/protoc.zip \
&& unzip -q /opt/protoc.zip -d /opt/protobuf \
&& rm /opt/protoc.zip

####
# Install shellcheck (shell script lint)
Expand Down Expand Up @@ -165,7 +162,7 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]
####

####
# OpenJDK 17
# OpenJDK 21
# hadolint ignore=DL3008
RUN apt-get -q update \
&& DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y openjdk-21-jdk \
Expand Down Expand Up @@ -197,7 +194,7 @@ RUN apt-get -q update && apt-get -q install --no-install-recommends -y maven \
&& rm -rf /var/lib/apt/lists/*

######
# Install python3 and pylint3
# Install python3 and pylint4
# astroid and pylint go hand-in-hand. Upgrade both at the same time.
######
# hadolint ignore=DL3008,DL3013
Expand Down Expand Up @@ -226,13 +223,13 @@ RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
&& python3 /tmp/get-pip.py --break-system-packages \
&& rm /usr/local/bin/pip /tmp/get-pip.py \
&& pip3 install --break-system-packages -v \
astroid==2.4.2 \
codespell==2.0 \
pylint==2.5.3 \
yamllint==1.24.2 \
astroid==4.0.3 \
codespell==2.4.1 \
pylint==4.0.4 \
yamllint==1.38.0 \
&& rm -rf /root/.cache \
&& mv /usr/local/bin/pylint /usr/local/bin/pylint3
RUN ln -s /usr/local/bin/pylint3 /usr/local/bin/pylint
&& mv /usr/local/bin/pylint /usr/local/bin/pylint4
RUN ln -s /usr/local/bin/pylint4 /usr/local/bin/pylint
RUN ln -s /usr/local/bin/pip3 /usr/local/bin/pip

###
Expand All @@ -241,8 +238,8 @@ RUN ln -s /usr/local/bin/pip3 /usr/local/bin/pip
# hadolint ignore=DL3008
RUN apt-get update && apt-get install --no-install-recommends -y nodejs npm \
&& npm install -g \
jshint@2.12.0 \
markdownlint-cli@0.23.2 \
jshint@2.13.6 \
markdownlint-cli@0.46.0 \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* /root/.npm

Expand Down