Skip to content

Conversation

@ayushtkn
Copy link
Member

No description provided.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 27m 18s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 2m 6s Maven dependency ordering for branch
+1 💚 mvninstall 10m 26s master passed
+1 💚 compile 1m 7s master passed
+1 💚 checkstyle 1m 7s master passed
+1 💚 javadoc 1m 1s master passed
+0 🆗 spotbugs 1m 31s tez-common in master has 13 extant spotbugs warnings.
+0 🆗 spotbugs 0m 51s tez-tests in master has 6 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 0m 38s the patch passed
+1 💚 codespell 0m 27s No new issues.
+1 💚 compile 0m 37s the patch passed
+1 💚 javac 0m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 19s the patch passed
+1 💚 javadoc 0m 21s the patch passed
+1 💚 spotbugs 1m 33s the patch passed
_ Other Tests _
+1 💚 unit 0m 33s tez-common in the patch passed.
+1 💚 unit 40m 29s tez-tests in the patch passed.
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
92m 30s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/1/artifact/out/Dockerfile
GITHUB PR #439
Optional Tests dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile
uname Linux 466d5ef3ee01 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-439/src/.yetus/personality.sh
git revision master / bb1bdee
Default Java Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/1/testReport/
Max. process+thread count 1038 (vs. ulimit of 5500)
modules C: tez-common tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/1/console
versions git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

Path outputDir = Paths.get(ProfileServlet.OUTPUT_DIR).toAbsolutePath().normalize();
Path requestedPath = outputDir.resolve(queriedFile).normalize();

if (!requestedPath.startsWith(outputDir)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about an additional status here:

    response.setStatus(HttpServletResponse.SC_FORBIDDEN);

@abstractdog abstractdog self-requested a review October 31, 2025 09:07
Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 2m 3s Maven dependency ordering for branch
+1 💚 mvninstall 10m 10s master passed
+1 💚 compile 1m 6s master passed
+1 💚 checkstyle 1m 5s master passed
+1 💚 javadoc 1m 1s master passed
+0 🆗 spotbugs 1m 33s tez-common in master has 13 extant spotbugs warnings.
+0 🆗 spotbugs 0m 53s tez-tests in master has 6 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 0m 39s the patch passed
+1 💚 codespell 0m 27s No new issues.
+1 💚 compile 0m 36s the patch passed
+1 💚 javac 0m 36s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 17s the patch passed
+1 💚 javadoc 0m 22s the patch passed
+1 💚 spotbugs 1m 36s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s tez-common in the patch passed.
+1 💚 unit 41m 1s tez-tests in the patch passed.
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
66m 12s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/2/artifact/out/Dockerfile
GITHUB PR #439
Optional Tests dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile
uname Linux d68bdc0a5877 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-439/src/.yetus/personality.sh
git revision master / b6ca7a8
Default Java Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/2/testReport/
Max. process+thread count 1037 (vs. ulimit of 5500)
modules C: tez-common tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-439/2/console
versions git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@ayushtkn ayushtkn merged commit 5775337 into apache:master Oct 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants