-
Notifications
You must be signed in to change notification settings - Fork 440
TEZ-4652: ASF logo is too big #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| #banner .pull-right img { | ||
| height: 100%; | ||
| width: auto; | ||
| padding: 4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
🎊 +1 overall
This message was automatically generated. |
zabetak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. In fact, since there is no obligation/requirement to have the ASF logo in the project's website we could even drop it completely.
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@zabetak I was planning to merge this, Just wanted to confirm if you are ok with merging this. Maybe we can discuss removal of ASF logo separately, maybe with wider audience on dev@ if you feel so |
|
@ayushtkn Sure, I am ok to merge this that's why I approved the PR. Don't feel strongly about the removal but it can certainly make things simpler from both legal and visual part :) |


Now, we see a very outstanding ASF logo.
https://tez.apache.org/
Migrate to SVG
The official site does not mention the existence of asf_logo_wide.png. Though it is still available, I'm not sure if it is permanent. So, this will unlink it and use the SVG file.
Use the absolute size
The original one used a relative size so that the entire height becomes 82px. As
asf_logo_widebecomes much larger, this PR switched to the absolute size & auto-resize.