TEZ-4646: Periodic jstack collection for tez (tez.thread.dump.interval) only collects jstacks once.

[ayushtkn]

Added an option for initial delay & Fixed the periodic schedule so multiple jstacks are captured.

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	32m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ master Compile Tests _
+0 🆗	mvndep	1m 59s		Maven dependency ordering for branch
+1 💚	mvninstall	10m 39s		master passed
+1 💚	compile	1m 42s		master passed
+1 💚	checkstyle	1m 24s		master passed
+1 💚	javadoc	1m 32s		master passed
+0 🆗	spotbugs	2m 16s		tez-api in master has 610 extant spotbugs warnings.
+0 🆗	spotbugs	0m 54s		tez-runtime-internals in master has 114 extant spotbugs warnings.
+0 🆗	spotbugs	0m 52s		tez-tests in master has 6 extant spotbugs warnings.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 8s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 10s		the patch passed
+1 💚	codespell	0m 31s		No new issues.
+1 💚	compile	1m 8s		the patch passed
+1 💚	javac	1m 8s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 30s		the patch passed
+1 💚	javadoc	0m 48s		the patch passed
-1 ❌	spotbugs	0m 59s	/new-spotbugs-tez-runtime-internals.html	tez-runtime-internals generated 1 new + 113 unchanged - 1 fixed = 114 total (was 114)
			_ Other Tests _
+1 💚	unit	2m 19s		tez-api in the patch passed.
+1 💚	unit	0m 52s		tez-runtime-internals in the patch passed.
+1 💚	unit	41m 44s		tez-tests in the patch passed.
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		108m 41s

Reason	Tests
SpotBugs	module:tez-runtime-internals
	Exception thrown in class org.apache.tez.runtime.TezThreadDumpHelper at new org.apache.tez.runtime.TezThreadDumpHelper(long, long, Configuration) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. At TezThreadDumpHelper.java:at new org.apache.tez.runtime.TezThreadDumpHelper(long, long, Configuration) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. At TezThreadDumpHelper.java:[line 71]

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-425/1/artifact/out/Dockerfile
GITHUB PR	#425
Optional Tests	dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile
uname	Linux 0334a9746d14 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-425/src/.yetus/personality.sh
git revision	master / 785bf8a
Default Java	Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-425/1/testReport/
Max. process+thread count	974 (vs. ulimit of 5500)
modules	C: tez-api tez-runtime-internals tez-tests U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-425/1/console
versions	git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

[ayushtkn]

the spotbug warning isn't induced in this PR, flagging the already existing one. the count stays the same 114 (was 114)

[abstractdog]

what about harmonizing the variable names from periodicThreadDumpFrequency + initialDelay to something like: threadDumpFrequency + threadDumpInitialDelay or even frequency + initialDelay to reflect that these variables will configure the very-same executor

also, if it's called something frequency at some point, let it be called the same in the function (instead of duration)

[abstractdog]

looks good to me @ayushtkn, minor comment about naming

[abstractdog]

+1

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ master Compile Tests _
+0 🆗	mvndep	1m 54s		Maven dependency ordering for branch
+1 💚	mvninstall	10m 35s		master passed
+1 💚	compile	1m 51s		master passed
+1 💚	checkstyle	1m 32s		master passed
+1 💚	javadoc	1m 43s		master passed
+0 🆗	spotbugs	2m 37s		tez-api in master has 610 extant spotbugs warnings.
+0 🆗	spotbugs	1m 11s		tez-runtime-internals in master has 114 extant spotbugs warnings.
+0 🆗	spotbugs	0m 57s		tez-tests in master has 6 extant spotbugs warnings.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 21s		the patch passed
+1 💚	codespell	0m 36s		No new issues.
+1 💚	compile	1m 20s		the patch passed
+1 💚	javac	1m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 36s		the patch passed
+1 💚	javadoc	0m 57s		the patch passed
-1 ❌	spotbugs	1m 8s	/new-spotbugs-tez-runtime-internals.html	tez-runtime-internals generated 1 new + 113 unchanged - 1 fixed = 114 total (was 114)
			_ Other Tests _
+1 💚	unit	2m 19s		tez-api in the patch passed.
+1 💚	unit	0m 53s		tez-runtime-internals in the patch passed.
+1 💚	unit	43m 41s		tez-tests in the patch passed.
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		81m 43s

Reason	Tests
SpotBugs	module:tez-runtime-internals
	Exception thrown in class org.apache.tez.runtime.TezThreadDumpHelper at new org.apache.tez.runtime.TezThreadDumpHelper(long, long, Configuration) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. At TezThreadDumpHelper.java:at new org.apache.tez.runtime.TezThreadDumpHelper(long, long, Configuration) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. At TezThreadDumpHelper.java:[line 72]

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-425/2/artifact/out/Dockerfile
GITHUB PR	#425
Optional Tests	dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile
uname	Linux a5bf8f54ab2a 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-425/src/.yetus/personality.sh
git revision	master / cc8f8fb
Default Java	Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-425/2/testReport/
Max. process+thread count	1039 (vs. ulimit of 5500)
modules	C: tez-api tez-runtime-internals tez-tests U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-425/2/console
versions	git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0
Powered by	Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.