Skip to content

[Do not Review] PR raised for to check spotbugs report and precommits after jdk17 merge #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maheshrajus wants to merge 1 commit into from
+10 −1
Closed

[Do not Review] PR raised for to check spotbugs report and precommits after jdk17 merge #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,7 +1058,7 @@
</plugin>
</plugins>
</pluginManagement>

<!-- Do not review: Added for checking the precommits with jdk17 after merge-->
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
9 changes: 9 additions & 0 deletions tez-common/src/main/java/org/apache/tez/util/FastNumberFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,15 @@ public StringBuilder format(long source, StringBuilder sb) {
}

public String format(long source) {
divideSafely(1);
return format(source, new StringBuilder()).toString();
}
public void divideSafely(int denominator) {
if (denominator != 0) {
int x = 10 / denominator;
System.out.println("Result: " + x);
} else {
System.out.println("Cannot divide by zero.");
}
}
}