Skip to content

TEZ-4585: Fix counters for speculation. #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushtkn merged 1 commit into from
Nov 4, 2024
Merged

TEZ-4585: Fix counters for speculation. #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/TaskImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,6 @@ private static class RedundantScheduleTransition
@Override
public void transition(TaskImpl task, TaskEvent event) {
LOG.info("Scheduling a redundant attempt for task " + task.taskId);
task.counters.findCounter(TaskCounter.NUM_SPECULATIONS).increment(1);
TaskAttempt earliestUnfinishedAttempt = null;
for (TaskAttempt ta : task.attempts.values()) {
// find the oldest running attempt
Expand All @@ -1063,6 +1062,7 @@ public void transition(TaskImpl task, TaskEvent event) {
task.getTaskID(), task.commitAttempt);
return;
}
task.counters.findCounter(TaskCounter.NUM_SPECULATIONS).increment(1);
task.addAndScheduleAttempt(earliestUnfinishedAttempt.getTaskAttemptID());
}
}
Expand Down