Skip to content

TEZ-4526: Avoid calling LocationProvider#getPreferredLocations multiple times while generating grouped splits #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abstractdog merged 1 commit into from
Jan 9, 2024
Merged

TEZ-4526: Avoid calling LocationProvider#getPreferredLocations multiple times while generating grouped splits #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tez-mapreduce/src/main/java/org/apache/tez/mapreduce/grouper/TezSplitGrouper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,12 @@ public List<GroupedSplitContainer> getGroupedSplits(Configuration conf,

long totalLength = 0;
Map<String, LocationHolder> distinctLocations = createLocationsMap(conf);
Map<SplitContainer, String[]> splitToLocationsMap = new HashMap<>(originalSplits.size());
// go through splits and add them to locations
for (SplitContainer split : originalSplits) {
totalLength += estimator.getEstimatedSize(split);
String[] locations = locationProvider.getPreferredLocations(split);
splitToLocationsMap.put(split, locations);
if (locations == null || locations.length == 0) {
locations = emptyLocations;
allSplitsHaveLocalhost = false;
Expand Down Expand Up @@ -293,7 +295,7 @@ public List<GroupedSplitContainer> getGroupedSplits(Configuration conf,
groupedSplits = new ArrayList<GroupedSplitContainer>(originalSplits.size());
for (SplitContainer split : originalSplits) {
GroupedSplitContainer newSplit =
new GroupedSplitContainer(1, wrappedInputFormatName, cleanupLocations(locationProvider.getPreferredLocations(split)),
new GroupedSplitContainer(1, wrappedInputFormatName, cleanupLocations(splitToLocationsMap.get(split)),
null);
newSplit.addSplit(split);
groupedSplits.add(newSplit);
Expand All @@ -314,7 +316,7 @@ public List<GroupedSplitContainer> getGroupedSplits(Configuration conf,
Set<String> locSet = new HashSet<String>();
for (SplitContainer split : originalSplits) {
locSet.clear();
String[] locations = locationProvider.getPreferredLocations(split);
String[] locations = splitToLocationsMap.get(split);
if (locations == null || locations.length == 0) {
locations = emptyLocations;
}
Expand Down Expand Up @@ -408,7 +410,7 @@ public List<GroupedSplitContainer> getGroupedSplits(Configuration conf,
groupLocation = null;
} else if (doingRackLocal) {
for (SplitContainer splitH : group) {
String[] locations = locationProvider.getPreferredLocations(splitH);
String[] locations = splitToLocationsMap.get(splitH);
if (locations != null) {
for (String loc : locations) {
if (loc != null) {
Expand Down Expand Up @@ -503,7 +505,7 @@ public List<GroupedSplitContainer> getGroupedSplits(Configuration conf,
}
numRackSplitsToGroup--;
rackSet.clear();
String[] locations = locationProvider.getPreferredLocations(split);
String[] locations = splitToLocationsMap.get(split);
if (locations == null || locations.length == 0) {
locations = emptyLocations;
}
Expand Down