Skip to content

Conversation

@abstractdog
Copy link
Contributor

@abstractdog abstractdog commented Jun 12, 2023

As described in jira, mvn site command fails for some modules. Instead of taking care of javadoc compliance of some non-production modules, it would make sense disable the plugin for all of the modules for which javadocs are not published,

@tez-yetus

This comment was marked as outdated.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference this is mentioned on this ticket: MJAVADOC-274

I tried this locally, was able to repro & post fix it works for me.

Changes LGTM

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 22m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 7m 26s Maven dependency ordering for branch
+1 💚 mvninstall 11m 9s master passed
+1 💚 compile 4m 25s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 compile 4m 2s master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚 javadoc 4m 19s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javadoc 3m 41s master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 5m 29s the patch passed
+1 💚 compile 4m 18s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javac 4m 18s the patch passed
+1 💚 compile 4m 4s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚 javac 4m 4s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 5s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 43s tez-api in the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
+1 💚 javadoc 0m 36s tez-runtime-library in the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
+1 💚 javadoc 0m 34s tez-mapreduce in the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
+1 💚 javadoc 1m 17s root-jdkUbuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 generated 0 new + 29 unchanged - 52 fixed = 29 total (was 81)
+1 💚 javadoc 2m 58s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Other Tests _
+1 💚 unit 2m 34s tez-api in the patch passed.
+1 💚 unit 6m 9s tez-runtime-library in the patch passed.
+1 💚 unit 1m 40s tez-mapreduce in the patch passed.
+1 💚 unit 74m 27s root in the patch passed.
+1 💚 asflicense 2m 3s The patch does not generate ASF License warnings.
166m 14s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-288/2/artifact/out/Dockerfile
GITHUB PR #288
JIRA Issue TEZ-4495
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux affa74050494 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 86b1199
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-288/2/testReport/
Max. process+thread count 2100 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-library tez-mapreduce . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-288/2/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog merged commit a1a8f20 into apache:master Jun 19, 2023
@abstractdog
Copy link
Contributor Author

merged this as it blocked precommit mvnsite, thanks @ayushtkn for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants