Skip to content

Conversation

@abstractdog
Copy link
Contributor

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@abstractdog abstractdog changed the title TEZ-4467: Migrate from Travis CI to GitHub Actions TEZ-4467: Migrate from Travis CI to GitHub Actions - pt2: remove .travis.yml Feb 15, 2023
@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 yamllint 0m 1s The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
_ Other Tests _
+1 💚 asflicense 1m 1s The patch does not generate ASF License warnings.
2m 21s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/5/artifact/out/Dockerfile
GITHUB PR #269
JIRA Issue TEZ-4467
Optional Tests dupname asflicense yamllint
uname Linux ff2ae3c9b0e7 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / be99489
Max. process+thread count 46 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/5/console
versions git=2.34.1 maven=3.6.3 yamllint=1.24.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 15m 39s master passed
+1 💚 compile 2m 16s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 compile 2m 8s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚 javadoc 2m 36s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 javadoc 1m 50s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
_ Patch Compile Tests _
+1 💚 mvninstall 3m 59s the patch passed
+1 💚 compile 2m 12s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 javac 2m 12s the patch passed
+1 💚 compile 1m 58s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
+1 💚 javac 1m 58s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 yamllint 0m 0s The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚 javadoc 2m 3s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04
+1 💚 javadoc 1m 45s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08
_ Other Tests _
+1 💚 unit 73m 22s root in the patch passed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
112m 14s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/4/artifact/out/Dockerfile
GITHUB PR #269
JIRA Issue TEZ-4467
Optional Tests dupname asflicense javac javadoc unit xml compile yamllint
uname Linux 2151293f45d3 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / be99489
Default Java Private Build-1.8.0_352-8u352-ga-1~22.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/4/testReport/
Max. process+thread count 1923 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-269/4/console
versions git=2.34.1 maven=3.6.3 yamllint=1.24.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor Author

can you please approve this one @rbalamohan, @jteagles?
here is the history:

  1. I needed to merge another PR to see GitHub actions in action :) that's why it successfully kicked off 4 different Build CI steps here (TEZ-4467: Migrate from Travis CI to GitHub Actions - initial commit started from GitHub UI #270)
  2. this PR is about to remove .travis.yml
  3. also confirmed that the background precommit test runs (see results above)

travis is EOL from Feb15, so please review and let me merge this one

@abstractdog
Copy link
Contributor Author

please someone review, this is already working on master, we should cleanup the old travis.yml

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Travis CI is gone, good to cleanup

@abstractdog
Copy link
Contributor Author

LGTM Travis CI is gone, good to cleanup

thanks @ayushtkn for the review!
I'm about to merge this even with the absence of a tez committer review, this is an obvious cleanup task

@ayushtkn
Copy link
Member

ayushtkn commented May 4, 2023

hmm, no say in project maters but worth exploring CTR for Tez
https://www.apache.org/foundation/glossary.html#CommitThenReview

@ayushtkn
Copy link
Member

ayushtkn commented May 4, 2023

@abstractdog abstractdog merged commit 6722ef3 into apache:master Jun 12, 2023
@abstractdog
Copy link
Contributor Author

thanks @ayushtkn for taking a look
CTR is definitely the way to go in case of Tez considering the current state of the community, let me think about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants