TEZ-4385: Update checkstyle.xml and partially update the code

[LA-Toth]

As of now the codebase doesn't match the checkstyle configuration. I updated the config file to be sometimes stricter, sometimes more permissive compared to the previous version. As the code can't be updated in a single step, this pull request contains the simplest indentation changes (further PRs are needed).

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 14s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 258 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	6m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	10m 34s	master passed
+1 💚	compile	17m 33s	master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	16m 7s	master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	22m 59s	master passed
+1 💚	javadoc	15m 34s	master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	14m 17s	master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	spotbugs	0m 52s	Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗	findbugs	0m 29s	branch/tez-build-tools no findbugs output file (findbugsXml.xml)
+0 🆗	findbugs	6m 6s	root in master has 2 extant findbugs warnings.
+0 🆗	findbugs	0m 50s	tez-tools/analyzers/job-analyzer in master has 4 extant findbugs warnings.
-1 ❌	findbugs	0m 33s	tez-tfile-parser in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	13m 11s	the patch passed
+1 💚	compile	17m 8s	the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	17m 8s	the patch passed
+1 💚	compile	16m 7s	the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	16m 7s	the patch passed
+1 💚	checkstyle	0m 44s	hadoop-shim: The patch generated 0 new + 9 unchanged - 3 fixed = 9 total (was 12)
-0 ⚠️	checkstyle	1m 5s	tez-api: The patch generated 230 new + 731 unchanged - 446 fixed = 961 total (was 1177)
+1 💚	checkstyle	0m 28s	The patch passed checkstyle in tez-build-tools
-0 ⚠️	checkstyle	0m 37s	tez-common: The patch generated 39 new + 58 unchanged - 111 fixed = 97 total (was 169)
-0 ⚠️	checkstyle	0m 43s	tez-runtime-internals: The patch generated 87 new + 153 unchanged - 142 fixed = 240 total (was 295)
-0 ⚠️	checkstyle	1m 29s	tez-runtime-library: The patch generated 634 new + 1025 unchanged - 918 fixed = 1659 total (was 1943)
-0 ⚠️	checkstyle	1m 14s	tez-mapreduce: The patch generated 746 new + 554 unchanged - 411 fixed = 1300 total (was 965)
-0 ⚠️	checkstyle	0m 36s	tez-examples: The patch generated 19 new + 46 unchanged - 30 fixed = 65 total (was 76)
-0 ⚠️	checkstyle	1m 44s	tez-dag: The patch generated 1038 new + 1060 unchanged - 2229 fixed = 2098 total (was 3289)
-0 ⚠️	checkstyle	1m 1s	tez-tests: The patch generated 714 new + 249 unchanged - 946 fixed = 963 total (was 1195)
-0 ⚠️	checkstyle	0m 37s	tez-ext-service-tests: The patch generated 12 new + 53 unchanged - 71 fixed = 65 total (was 124)
-0 ⚠️	checkstyle	0m 36s	tez-plugins/tez-protobuf-history-plugin: The patch generated 23 new + 8 unchanged - 85 fixed = 31 total (was 93)
-0 ⚠️	checkstyle	0m 36s	tez-plugins/tez-yarn-timeline-history: The patch generated 10 new + 24 unchanged - 155 fixed = 34 total (was 179)
-0 ⚠️	checkstyle	0m 35s	tez-plugins/tez-yarn-timeline-history-with-acls: The patch generated 9 new + 20 unchanged - 8 fixed = 29 total (was 28)
-0 ⚠️	checkstyle	0m 34s	tez-plugins/tez-yarn-timeline-cache-plugin: The patch generated 1 new + 3 unchanged - 18 fixed = 4 total (was 21)
-0 ⚠️	checkstyle	0m 35s	tez-plugins/tez-yarn-timeline-history-with-fs: The patch generated 13 new + 15 unchanged - 69 fixed = 28 total (was 84)
-0 ⚠️	checkstyle	0m 40s	tez-plugins/tez-history-parser: The patch generated 49 new + 94 unchanged - 28 fixed = 143 total (was 122)
-0 ⚠️	checkstyle	0m 37s	tez-plugins/tez-aux-services: The patch generated 21 new + 33 unchanged - 68 fixed = 54 total (was 101)
-0 ⚠️	checkstyle	0m 39s	tez-tools/analyzers/job-analyzer: The patch generated 60 new + 36 unchanged - 58 fixed = 96 total (was 94)
-0 ⚠️	checkstyle	0m 34s	tez-tools/tez-javadoc-tools: The patch generated 9 new + 19 unchanged - 6 fixed = 28 total (was 25)
+1 💚	checkstyle	0m 31s	hadoop-shim-impls/hadoop-shim-2.8: The patch generated 0 new + 1 unchanged - 6 fixed = 1 total (was 7)
-0 ⚠️	checkstyle	4m 45s	root: The patch generated 3722 new + 4183 unchanged - 5816 fixed = 7905 total (was 9999)
+1 💚	checkstyle	0m 33s	The patch passed checkstyle in hadoop-shim-2.7
-0 ⚠️	checkstyle	0m 33s	tez-tools/tez-tfile-parser: The patch generated 1 new + 2 unchanged - 2 fixed = 3 total (was 4)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	javadoc	15m 20s	the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	14m 12s	the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	findbugs	0m 29s	tez-build-tools has no data from findbugs
-1 ❌	findbugs	0m 35s	tez-tfile-parser in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 39s	hadoop-shim in the patch passed.
+1 💚	unit	2m 28s	tez-api in the patch passed.
+1 💚	unit	0m 30s	tez-build-tools in the patch passed.
+1 💚	unit	0m 46s	tez-common in the patch passed.
+1 💚	unit	0m 58s	tez-runtime-internals in the patch passed.
+1 💚	unit	5m 18s	tez-runtime-library in the patch passed.
+1 💚	unit	1m 39s	tez-mapreduce in the patch passed.
+1 💚	unit	0m 36s	tez-examples in the patch passed.
+1 💚	unit	5m 22s	tez-dag in the patch passed.
+1 💚	unit	38m 55s	tez-tests in the patch passed.
+1 💚	unit	4m 18s	tez-ext-service-tests in the patch passed.
+1 💚	unit	0m 49s	tez-protobuf-history-plugin in the patch passed.
+1 💚	unit	1m 57s	tez-yarn-timeline-history in the patch passed.
+1 💚	unit	2m 11s	tez-yarn-timeline-history-with-acls in the patch passed.
+1 💚	unit	0m 39s	tez-yarn-timeline-cache-plugin in the patch passed.
+1 💚	unit	1m 56s	tez-yarn-timeline-history-with-fs in the patch passed.
+1 💚	unit	2m 44s	tez-history-parser in the patch passed.
+1 💚	unit	3m 6s	tez-aux-services in the patch passed.
+1 💚	unit	3m 5s	job-analyzer in the patch passed.
+1 💚	unit	0m 38s	tez-javadoc-tools in the patch passed.
+1 💚	unit	0m 39s	hadoop-shim-2.8 in the patch passed.
+1 💚	unit	69m 23s	root in the patch passed.
+1 💚	unit	0m 38s	hadoop-shim-2.7 in the patch passed.
+1 💚	unit	0m 38s	tez-tfile-parser in the patch passed.
+1 💚	asflicense	13m 19s	The patch does not generate ASF License warnings.
		439m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/Dockerfile
GITHUB PR	#219
JIRA Issue	TEZ-4385
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile xml
uname	Linux 58dfa12ed2bd 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / e5a5578
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
findbugs	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/branch-findbugs-tez-tools_tez-tfile-parser.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-api.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-common.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-runtime-internals.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-runtime-library.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-mapreduce.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-examples.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-dag.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-tests.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-ext-service-tests.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-protobuf-history-plugin.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-yarn-timeline-history.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-yarn-timeline-history-with-acls.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-yarn-timeline-cache-plugin.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-yarn-timeline-history-with-fs.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-history-parser.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-aux-services.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-tools_analyzers_job-analyzer.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-root.txt
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-tools_tez-tfile-parser.txt
findbugs	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/patch-findbugs-tez-tools_tez-tfile-parser.txt
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/testReport/
Max. process+thread count	2089 (vs. ulimit of 5500)
modules	C: hadoop-shim tez-api tez-build-tools tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-yarn-timeline-cache-plugin tez-plugins/tez-yarn-timeline-history-with-fs tez-plugins/tez-history-parser tez-plugins/tez-aux-services tez-tools/analyzers/job-analyzer tez-tools/tez-javadoc-tools hadoop-shim-impls/hadoop-shim-2.8 . hadoop-shim-impls/hadoop-shim-2.7 tez-tools/tez-tfile-parser U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/console
versions	git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.