TEZ-4419: Upgrade node and yarn version and fix npm security issues in Tez UI module #215
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -212,16 +212,16 @@ [email protected]: | |
| version "0.9.0" | ||
| resolved "https://registry.yarnpkg.com/async/-/async-0.9.0.tgz#ac3613b1da9bed1b47510bb4651b8931e47146c7" | ||
|
|
||
| [email protected], async@^2.0.1: | ||
| version "2.6.4" | ||
| resolved "https://registry.yarnpkg.com/async/-/async-2.6.4.tgz#706b7ff6084664cd7eae713f6f965433b5504221" | ||
| dependencies: | ||
| lodash "^4.17.14" | ||
|
|
||
| async@^1.0.0: | ||
| version "1.5.2" | ||
| resolved "https://registry.yarnpkg.com/async/-/async-1.5.2.tgz#ec6a61ae56480c0c3cb241c95618e20892f9672a" | ||
|
|
||
| async@~0.2.6, async@~0.2.9: | ||
| version "0.2.10" | ||
| resolved "https://registry.yarnpkg.com/async/-/async-0.2.10.tgz#b6bbe0b0674b9d719708ca38de8c237cb526c3d1" | ||
|
|
@@ -473,6 +473,12 @@ [email protected]: | |
| dependencies: | ||
| hoek "2.x.x" | ||
|
|
||
| [email protected]: | ||
| version "7.3.0" | ||
| resolved "https://registry.yarnpkg.com/boom/-/boom-7.3.0.tgz#733a6d956d33b0b1999da3fe6c12996950d017b9" | ||
| dependencies: | ||
| hoek "6.x.x" | ||
|
|
||
| [email protected]: | ||
| version "0.6.1" | ||
| resolved "https://registry.yarnpkg.com/bower-config/-/bower-config-0.6.1.tgz#7093155688bef44079bf4cb32d189312c87ded60" | ||
|
|
@@ -1180,11 +1186,11 @@ cross-spawn-async@^2.0.0: | |
| lru-cache "^4.0.0" | ||
| which "^1.2.8" | ||
|
|
||
| [email protected], [email protected]: | ||
| version "4.1.2" | ||
| resolved "https://registry.yarnpkg.com/cryptiles/-/cryptiles-4.1.2.tgz#363c9ab5c859da9d2d6fb901b64d980966181184" | ||
| dependencies: | ||
| boom "7.x.x" | ||
|
|
||
| [email protected]: | ||
| version "0.5.3" | ||
|
|
@@ -2472,6 +2478,10 @@ [email protected]: | |
| version "2.16.3" | ||
| resolved "https://registry.yarnpkg.com/hoek/-/hoek-2.16.3.tgz#20bb7403d3cea398e91dc4710a8ff1b8274a25ed" | ||
|
|
||
| [email protected]: | ||
| version "6.1.3" | ||
| resolved "https://registry.yarnpkg.com/hoek/-/hoek-6.1.3.tgz#73b7d33952e01fe27a38b0457294b79dd8da242c" | ||
|
|
||
| home-or-tmp@^1.0.0: | ||
| version "1.0.0" | ||
| resolved "https://registry.yarnpkg.com/home-or-tmp/-/home-or-tmp-1.0.0.tgz#4b9f1e40800c3e50c6c27f781676afcce71f3985" | ||
|
|
@@ -2789,9 +2799,9 @@ json-parse-helpfulerror@^1.0.2: | |
| dependencies: | ||
| jju "^1.1.0" | ||
|
|
||
| [email protected], [email protected]: | ||
| version "0.4.0" | ||
| resolved "https://registry.yarnpkg.com/json-schema/-/json-schema-0.4.0.tgz#f7de4cf6efab838ebaeb3236474cbba5a1930ab5" | ||
|
|
||
| json-stable-stringify@^1.0.0, json-stable-stringify@^1.0.1: | ||
| version "1.0.1" | ||
|
|
@@ -2821,9 +2831,9 @@ jsonify@~0.0.0: | |
| version "0.0.0" | ||
| resolved "https://registry.yarnpkg.com/jsonify/-/jsonify-0.0.0.tgz#2c74b6ee41d93ca51b7b5aaee8f503631d252a73" | ||
|
|
||
| jsonpointer@4.1.0, jsonpointer@^4.0.0: | ||
| version "4.1.0" | ||
| resolved "https://registry.yarnpkg.com/jsonpointer/-/jsonpointer-4.1.0.tgz#501fb89986a2389765ba09e6053299ceb4f2c2cc" | ||
|
|
||
| jsprim@^1.2.2: | ||
| version "1.4.0" | ||
|
|
@@ -2916,14 +2926,6 @@ lodash-node@^3.4.0: | |
| version "3.10.2" | ||
| resolved "https://registry.yarnpkg.com/lodash-node/-/lodash-node-3.10.2.tgz#2598d5b1b54e6a68b4cb544e5c730953cbf632f7" | ||
|
|
||
| lodash._baseassign@^3.0.0: | ||
| version "3.2.0" | ||
| resolved "https://registry.yarnpkg.com/lodash._baseassign/-/lodash._baseassign-3.2.0.tgz#8c38a099500f215ad09e59f1722fd0c52bfe0a4e" | ||
|
|
@@ -2944,10 +2946,6 @@ lodash._basecopy@^3.0.0: | |
| version "3.0.1" | ||
| resolved "https://registry.yarnpkg.com/lodash._basecopy/-/lodash._basecopy-3.0.1.tgz#8da0e6a876cf344c0ad8a54882111dd3c5c7ca36" | ||
|
|
||
| lodash._baseindexof@^3.0.0: | ||
| version "3.1.0" | ||
| resolved "https://registry.yarnpkg.com/lodash._baseindexof/-/lodash._baseindexof-3.1.0.tgz#fe52b53a1c6761e42618d654e4a25789ed61822c" | ||
|
|
@@ -3021,14 +3019,6 @@ lodash.isarray@^3.0.0: | |
| version "3.0.4" | ||
| resolved "https://registry.yarnpkg.com/lodash.isarray/-/lodash.isarray-3.0.4.tgz#79e4eb88c36a8122af86f844aa9bcd851b5fbb55" | ||
|
|
||
| lodash.istypedarray@^3.0.0: | ||
| version "3.0.6" | ||
| resolved "https://registry.yarnpkg.com/lodash.istypedarray/-/lodash.istypedarray-3.0.6.tgz#c9a477498607501d8e8494d283b87c39281cef62" | ||
|
|
@@ -3041,32 +3031,9 @@ lodash.keys@^3.0.0: | |
| lodash.isarguments "^3.0.0" | ||
| lodash.isarray "^3.0.0" | ||
|
|
||
| [email protected], lodash.merge@^3.0.2, lodash.merge@^3.3.2, lodash.merge@^4.5.1: | ||
| version "4.6.2" | ||
| resolved "https://registry.yarnpkg.com/lodash.merge/-/lodash.merge-4.6.2.tgz#558aa53b43b661e1925a0afdfa36a9a1085fe57a" | ||
|
|
||
| lodash.pad@^4.1.0: | ||
| version "4.5.1" | ||
|
|
@@ -3090,13 +3057,6 @@ lodash.restparam@^3.0.0: | |
| version "3.6.1" | ||
| resolved "https://registry.yarnpkg.com/lodash.restparam/-/lodash.restparam-3.6.1.tgz#936a4e309ef330a7645ed4145986c85ae5b20805" | ||
|
|
||
| lodash.uniq@^3.2.2: | ||
| version "3.2.2" | ||
| resolved "https://registry.yarnpkg.com/lodash.uniq/-/lodash.uniq-3.2.2.tgz#146c36f25e75d19501ba402e88ba14937f63cd8b" | ||
|
|
@@ -3115,9 +3075,9 @@ lodash@^3.10.0, lodash@^3.6.0, lodash@^3.9.3: | |
| version "3.10.1" | ||
| resolved "https://registry.yarnpkg.com/lodash/-/lodash-3.10.1.tgz#5bf45e8e49ba4189e17d482789dfd15bd140b7b6" | ||
|
|
||
| lodash@^4.17.14: | ||
| version "4.17.21" | ||
| resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c" | ||
|
|
||
| lodash@~2.3.0: | ||
| version "2.3.0" | ||
|
|
@@ -3290,9 +3250,9 @@ minimatch@~0.2.9: | |
| lru-cache "2" | ||
| sigmund "~1.0.0" | ||
|
|
||
| [email protected], minimist@1.2.6, minimist@~0.0.1: | ||
| version "1.2.6" | ||
| resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.6.tgz#8637a5b759ea0d6e98702cfb3a9283323c93af44" | ||
|
|
||
| minimist@^1.1.0, minimist@^1.1.1: | ||
| version "1.2.0" | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can try with v16 ?
https://nodejs.org/en/about/releases/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slachiewicz When I update the node version to 16.15.1, this is the error that I get :
yarn run v1.6.0
(node:2298) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use
node --trace-deprecation ...to show where the warning was created)$ TMPDIR=tmp node/node ./node_modules/ember-cli/bin/ember build -prod
exports.dir = path.resolve(os.tmpDir());
^
TypeError: os.tmpDir is not a function
at Object. (/home/tez-ui/src/main/webapp/node_modules/temp/lib/temp.js:273:45)
at Module._compile (node:internal/modules/cjs/loader:1105:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Module.require (node:internal/modules/cjs/loader:1005:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object. (/home/amanraj2520/Repositories/wildfire-tez/tez-ui/src/main/webapp/node_modules/ember-cli/lib/tasks/install-blueprint.js:7:21)
at Module._compile (node:internal/modules/cjs/loader:1105:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I think this error means is that we need to replace all the places of occurrence of new Buffer() to either Buffer.alloc() or Buffer.from(). Let me know you thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably stack should be upgraded. I commented on Node's version because currently 16 is LTS version. I don't have experience with frontend tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thats true, but I think it will be another big change. I think we should make this change first and then work on upgrading the stack. Any thoughts ? @abstractdog @slachiewicz