TEZ-4411: Update FileSaver dependency #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Solution Credits: @abstractdog Please help with the review and merge as this is a blocker for other commits. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
thanks @guptanikhil007 |
Contributor
Author
|
@abstractdog There may be an issue with pre-commit pipeline. |
Contributor
Author
|
There is a failure on master but patch is passing: |
Contributor
|
@guptanikhil007 : I see, that's kind of my concern, as we want to fix precommit here too (not only local builds), I want to make sure that once we merge this change, precommit will work I mean, what you attached: ...exactly belongs to the log file I mentioned above: precommit is supposed to pick up the source code changes in the pull request, I'm just looking for the reason why it failed, and tried to fetch Teleborder version |
Contributor
Author
@abstractdog Build Steps: |
| "0.1.1": "7a13f6dba5a340e1cb9e0b64c1c711e4d7edaca1" | ||
| }, | ||
| "https://github.com/eligrey/FileSaver.js.git": { | ||
| "1.3.4": "b4a918669accb81f184c610d741a4a8e1306aa27" |
There was a problem hiding this comment.
I think it would make sense to point to same commit (eligrey/FileSaver.js@b7cf622) in this PR so there are no extra changes.
Upgrading can be handled in separate commit.
Contributor
|
thanks @guptanikhil007, makes sense, so it should work after merging |
Contributor
Author
|
The lowest bower version available is 1.2.0. @Deependra-Patel @abstractdog Should we go with 1.2.0? |
Contributor
I cannot tell honestly, I've just uploaded the one on my laptop to: https://issues.apache.org/jira/secure/attachment/13043100/FileSaver.js instead of manually looking for changes, please do the following: if all tests pass, I'm fine with the version, no matter which 1.x |
Contributor
Author
|
mvn test is passing with 1.2.0 |
abstractdog
approved these changes
Apr 29, 2022
Contributor
|
thanks @guptanikhil007 , I'm about to merge this soon |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
merged, created empty PR to check mvninstall phase: #207 |
What I meant was we could have kept the commit id |
asfgit
pushed a commit
that referenced
this pull request
Apr 30, 2022
…y Laszlo Bodor, Deependra Patel)
mudit1289
pushed a commit
to mudit1289/tez
that referenced
this pull request
Feb 25, 2023
…ewed by Laszlo Bodor, Deependra Patel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update FileSaver dependency to latest bower supported dependency
Why are the changes needed?
Previous dependency files were no longer available
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual tests.