Skip to content

TEZ-4407: Misleading split info in TezSplitGrouper logs when adjusting small splits #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abstractdog merged 4 commits into from
Dec 23, 2024
+14 −22
Merged

TEZ-4407: Misleading split info in TezSplitGrouper logs when adjusting small splits #202

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9033f8
TEZ-4407: Misleading split info in TezSplitGrouper logs when adjustin…
zabetak Apr 20, 2022
c715c0b
Clarify what happens when all spits are in localhost with log message
zabetak Jun 26, 2023
8f7797a
Group log messages and always print when bounds exceeded
zabetak Jun 26, 2023
d0384d4
Always print new desired splits even if not changed.
zabetak Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 14 additions & 22 deletions tez-mapreduce/src/main/java/org/apache/tez/mapreduce/grouper/TezSplitGrouper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,36 +247,28 @@ public List<GroupedSplitContainer> getGroupedSplits(Configuration conf,
"Invalid max/min group lengths. Required min>0, max>=min. " +
" max: " + maxLengthPerGroup + " min: " + minLengthPerGroup);
}
int newDesiredNumSplits = -1;
if (lengthPerGroup > maxLengthPerGroup) {
// splits too big to work. Need to override with max size.
int newDesiredNumSplits = (int)(totalLength/maxLengthPerGroup) + 1;
LOG.info("Desired splits: " + desiredNumSplits + " too small. " +
" Desired splitLength: " + lengthPerGroup +
" Max splitLength: " + maxLengthPerGroup +
" New desired splits: " + newDesiredNumSplits +
" Total length: " + totalLength +
" Original splits: " + originalSplits.size());

desiredNumSplits = newDesiredNumSplits;
newDesiredNumSplits = (int)(totalLength/maxLengthPerGroup) + 1;
} else if (lengthPerGroup < minLengthPerGroup) {
// splits too small to work. Need to override with size.
int newDesiredNumSplits = (int)(totalLength/minLengthPerGroup) + 1;
/**
* This is a workaround for systems like S3 that pass the same
* fake hostname for all splits.
*/
if (!allSplitsHaveLocalhost) {
desiredNumSplits = newDesiredNumSplits;
newDesiredNumSplits = (int)(totalLength/minLengthPerGroup) + 1;
if (allSplitsHaveLocalhost) {
// Workaround for systems like S3 that pass the same fake hostname for all splits.
LOG.info("Ignore {} configuration cause all splits seem to be on localhost.", TEZ_GROUPING_SPLIT_MIN_SIZE);
newDesiredNumSplits = desiredNumSplits;
}

LOG.info("Desired splits: " + desiredNumSplits + " too large. " +
" Desired splitLength: " + lengthPerGroup +
}
if (newDesiredNumSplits != -1) {
LOG.info("Desired splitLength " + lengthPerGroup + " exceeds min/max bounds. " +
" Min splitLength: " + minLengthPerGroup +
" New desired splits: " + newDesiredNumSplits +
" Final desired splits: " + desiredNumSplits +
" All splits have localhost: " + allSplitsHaveLocalhost +
" Max splitLength: " + maxLengthPerGroup +
" Desired splits: " + desiredNumSplits +
" New Desired splits: " + newDesiredNumSplits +
" Total length: " + totalLength +
" Original splits: " + originalSplits.size());
desiredNumSplits = newDesiredNumSplits;
}
}

Expand Down