Skip to content

Conversation

@ghanko
Copy link
Contributor

@ghanko ghanko commented Mar 31, 2022

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@abstractdog
Copy link
Contributor

@ghanko : is there a chance you can rebase this change and address the remaining related checkstyle issues?

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

Change-Id: I0cf2653338a74379bdfefc87430859aa114bbdfa
@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 24 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 5m 55s Maven dependency ordering for branch
+1 💚 mvninstall 10m 38s master passed
+1 💚 compile 10m 22s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 compile 10m 13s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 checkstyle 8m 18s master passed
+1 💚 javadoc 8m 37s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javadoc 8m 43s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗 spotbugs 0m 59s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 13m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 4m 54s the patch passed
+1 💚 compile 4m 47s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javac 4m 47s the patch passed
+1 💚 compile 4m 29s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 javac 4m 29s the patch passed
+1 💚 checkstyle 0m 21s tez-api: The patch generated 0 new + 161 unchanged - 16 fixed = 161 total (was 177)
+1 💚 checkstyle 0m 15s tez-common: The patch generated 0 new + 53 unchanged - 5 fixed = 53 total (was 58)
+1 💚 checkstyle 0m 13s tez-runtime-internals: The patch generated 0 new + 20 unchanged - 4 fixed = 20 total (was 24)
+1 💚 checkstyle 0m 24s tez-runtime-library: The patch generated 0 new + 234 unchanged - 67 fixed = 234 total (was 301)
+1 💚 checkstyle 0m 17s tez-mapreduce: The patch generated 0 new + 92 unchanged - 20 fixed = 92 total (was 112)
+1 💚 checkstyle 0m 13s tez-examples: The patch generated 0 new + 2 unchanged - 13 fixed = 2 total (was 15)
+1 💚 checkstyle 0m 26s tez-dag: The patch generated 0 new + 152 unchanged - 16 fixed = 152 total (was 168)
+1 💚 checkstyle 0m 18s tez-tests: The patch generated 0 new + 68 unchanged - 131 fixed = 68 total (was 199)
+1 💚 checkstyle 0m 12s tez-ext-service-tests: The patch generated 0 new + 7 unchanged - 2 fixed = 7 total (was 9)
+1 💚 checkstyle 0m 14s tez-plugins/tez-yarn-timeline-history: The patch generated 0 new + 44 unchanged - 1 fixed = 44 total (was 45)
+1 💚 checkstyle 0m 14s tez-plugins/tez-history-parser: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
+1 💚 checkstyle 0m 13s tez-tools/analyzers/job-analyzer: The patch generated 0 new + 2 unchanged - 2 fixed = 2 total (was 4)
+1 💚 checkstyle 0m 11s tez-tools/tez-javadoc-tools: The patch generated 0 new + 2 unchanged - 2 fixed = 2 total (was 4)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 4m 7s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javadoc 3m 48s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 findbugs 9m 58s the patch passed
_ Other Tests _
+1 💚 unit 2m 18s tez-api in the patch passed.
+1 💚 unit 0m 31s tez-common in the patch passed.
+1 💚 unit 0m 43s tez-runtime-internals in the patch passed.
+1 💚 unit 5m 59s tez-runtime-library in the patch passed.
+1 💚 unit 1m 25s tez-mapreduce in the patch passed.
+1 💚 unit 0m 20s tez-examples in the patch passed.
+1 💚 unit 5m 22s tez-dag in the patch passed.
+1 💚 unit 41m 0s tez-tests in the patch passed.
+1 💚 unit 4m 15s tez-ext-service-tests in the patch passed.
+1 💚 unit 1m 43s tez-yarn-timeline-history in the patch passed.
+1 💚 unit 2m 31s tez-history-parser in the patch passed.
+1 💚 unit 2m 54s job-analyzer in the patch passed.
+1 💚 unit 0m 19s tez-javadoc-tools in the patch passed.
+1 💚 asflicense 3m 28s The patch does not generate ASF License warnings.
190m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-197/6/artifact/out/Dockerfile
GITHUB PR #197
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 5ced6759ba56 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 65f9ee3
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-197/6/testReport/
Max. process+thread count 1448 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-plugins/tez-yarn-timeline-history tez-plugins/tez-history-parser tez-tools/analyzers/job-analyzer tez-tools/tez-javadoc-tools U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-197/6/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
I'm about to change the commit message to reflect that this commit includes lots of refactors other than final classes
thanks @ghanko , this is a great code quality improvement

@abstractdog abstractdog merged commit 2fd7df4 into apache:master Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants