Skip to content

TEZ-4359: ShuffleHandler: Make sure of properly releasing netty reference counted objects #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abstractdog merged 1 commit into from
Mar 10, 2022
Merged

TEZ-4359: ShuffleHandler: Make sure of properly releasing netty reference counted objects #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,7 +1499,6 @@ protected void sendError(ChannelHandlerContext ctx, HttpResponseStatus status) {
protected void sendError(ChannelHandlerContext ctx, String message, HttpResponseStatus status) {
FullHttpResponse response = new DefaultFullHttpResponse(HTTP_1_1, status);
sendError(ctx, message, response);
response.release();
}

protected void sendError(ChannelHandlerContext ctx, String message, FullHttpResponse response) {
Expand All @@ -1517,7 +1516,6 @@ private void sendFakeShuffleHeaderWithError(ChannelHandlerContext ctx, String me
header.write(out);

sendError(ctx, wrappedBuffer(out.getData(), 0, out.getLength()), fullResponse);
fullResponse.release();
}

protected void sendError(ChannelHandlerContext ctx, ByteBuf content,
Expand All @@ -1532,6 +1530,11 @@ protected void sendError(ChannelHandlerContext ctx, ByteBuf content,

// Close the connection as soon as the error message is sent.
ctx.channel().writeAndFlush(response).addListener(ChannelFutureListener.CLOSE);
/*
* The general rule of thumb is that the party that accesses a reference-counted object last
* is also responsible for the destruction of that reference-counted object.
*/
content.release();
}

@Override
Expand Down