Skip to content

TEZ-4357: Report url to logs in case of fetcher connection failure #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushtkn merged 1 commit into from
Jan 25, 2024
Merged

TEZ-4357: Report url to logs in case of fetcher connection failure #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/Fetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,8 +494,9 @@ protected HostFetchResult doHttpFetch() {
}

private HostFetchResult setupConnection(Collection<InputAttemptIdentifier> attempts) {
StringBuilder baseURI = null;
try {
StringBuilder baseURI = ShuffleUtils.constructBaseURIForShuffleHandler(host,
baseURI = ShuffleUtils.constructBaseURIForShuffleHandler(host,
port, partition, partitionCount, appId.toString(), dagIdentifier, httpConnectionParams.isSslShuffle());
this.url = ShuffleUtils.constructInputURL(baseURI.toString(), attempts,
httpConnectionParams.isKeepAlive());
Expand Down Expand Up @@ -547,9 +548,8 @@ private HostFetchResult setupConnection(Collection<InputAttemptIdentifier> attem
}
} else {
InputAttemptIdentifier firstAttempt = attempts.iterator().next();
LOG.warn(String.format(
"Fetch Failure while connecting from %s to: %s:%d, attempt: %s Informing ShuffleManager: ",
localHostname, host, port, firstAttempt), e);
LOG.warn("FETCH_FAILURE: Fetch Failure while connecting from {} to: {}:{}, attempt: {}, url: {}"
+ " Informing ShuffleManager", localHostname, host, port, firstAttempt, baseURI, e);
return new HostFetchResult(new FetchResult(host, port, partition, partitionCount, srcAttemptsRemaining.values()),
new InputAttemptFetchFailure[] { new InputAttemptFetchFailure(firstAttempt) }, true);
}
Expand Down
13 changes: 7 additions & 6 deletions ...a/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/FetcherOrderedGrouped.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,9 @@ private void invokeCopyFailedForFailedTasks(MapHost host,
boolean setupConnection(MapHost host, Collection<InputAttemptIdentifier> attempts)
throws IOException {
boolean connectSucceeded = false;
StringBuilder baseURI = null;
try {
StringBuilder baseURI = ShuffleUtils.constructBaseURIForShuffleHandler(host.getHost(),
baseURI = ShuffleUtils.constructBaseURIForShuffleHandler(host.getHost(),
host.getPort(), host.getPartitionId(), host.getPartitionCount(), applicationId, dagId, sslShuffle);
URL url = ShuffleUtils.constructInputURL(baseURI.toString(), attempts, httpConnectionParams.isKeepAlive());
httpConnection = ShuffleUtils.getHttpConnection(asyncHttp, url, httpConnectionParams,
Expand All @@ -364,13 +365,13 @@ boolean setupConnection(MapHost host, Collection<InputAttemptIdentifier> attempt
}
ioErrs.increment(1);
if (!connectSucceeded) {
LOG.warn(String.format("Failed to connect from %s to %s with %d inputs", localShuffleHost,
host, remaining.size()), ie);
LOG.warn("FETCH_FAILURE: Failed to connect from {} to {} with {} inputs, url: {}", localShuffleHost,
host, remaining.size(), baseURI, ie);
connectionErrs.increment(1);
} else {
LOG.warn(String.format(
"Failed to verify reply after connecting from %s to %s with %d inputs pending",
localShuffleHost, host, remaining.size()), ie);
LOG.warn(
"FETCH_FAILURE: Failed to verify reply after connecting from {} to {} with {} inputs pending, url: {}",
localShuffleHost, host, remaining.size(), baseURI, ie);
}

// At this point, either the connection failed, or the initial header verification failed.
Expand Down