TEZ-4333: Debug artifacts can include DAG plan in json format #149
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Oct 6, 2023
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Thanx @abstractdog , this sounds cool thing to do, dropped some minor comments/question.
rest LGTM
| String logFile = logDirs[new Random().nextInt(logDirs.length)] + File.separatorChar + newDag.getID() + "-" | ||
| + TezConstants.TEZ_PB_PLAN_JSON_NAME; | ||
|
|
||
| LOG.info("Writing DAG JSON plan to: " + logFile); |
Member
There was a problem hiding this comment.
should use placeholders
LOG.info("Writing DAG JSON plan to: {}", logFile);
| } | ||
|
|
||
| private void writePBJsonFile(DAGPlan dagPB, DAGImpl newDag) { | ||
| String logFile = logDirs[new Random().nextInt(logDirs.length)] + File.separatorChar + newDag.getID() + "-" |
Member
There was a problem hiding this comment.
I think other files like TEZ_PB_PLAN_TEXT_NAME are in tezSysStagingPath, should we keep these files also there?
tez/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java
Lines 211 to 214 in 5bba1ff
| printWriter.println(DAGUtils.generateSimpleJSONPlan(dagPB)); | ||
| printWriter.close(); | ||
| } catch (IOException | JSONException e) { | ||
| LOG.warn("Failed to write TEZ_PLAN JSON to " + outFile, e); |
Member
There was a problem hiding this comment.
should change to:
LOG.warn("Failed to write TEZ_PLAN JSON to {}", outFile, e);
| try { | ||
| PrintWriter printWriter = new PrintWriter(outFile, "UTF-8"); | ||
| printWriter.println(DAGUtils.generateSimpleJSONPlan(dagPB)); | ||
| printWriter.close(); |
Member
There was a problem hiding this comment.
I think this close should be in finally block or we should use try-with-resource for printWriter, else if printWriter.println(DAGUtils.generateSimpleJSONPlan(dagPB)); this throws exception, we won't be closing the printWritter
Member
|
@abstractdog I think If you address the comments this should be good to go :-) |
This was referenced Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.