Skip to content

Conversation

@abstractdog
Copy link
Contributor

No description provided.

@abstractdog abstractdog force-pushed the TEZ-4318 branch 2 times, most recently from 8488628 to 1946215 Compare August 1, 2021 12:52
@hadoop-yetus

This comment has been minimized.

@hadoop-yetus

This comment has been minimized.

@hadoop-yetus

This comment has been minimized.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 5m 10s Maven dependency ordering for branch
+1 💚 mvninstall 8m 35s master passed
+1 💚 compile 4m 0s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 3m 46s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 2m 17s master passed
+1 💚 javadoc 3m 44s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 55s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗 spotbugs 0m 41s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 0m 47s tez-tools in master has 2 extant findbugs warnings.
+0 🆗 findbugs 5m 48s root in master has 2 extant findbugs warnings.
+0 🆗 findbugs 0m 39s tez-tools/analyzers/job-analyzer in master has 4 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 1m 54s Maven dependency ordering for patch
+1 💚 mvninstall 5m 55s the patch passed
+1 💚 compile 4m 27s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 4m 27s the patch passed
+1 💚 compile 4m 8s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 4m 8s the patch passed
-0 ⚠️ checkstyle 0m 25s tez-tools: The patch generated 9 new + 47 unchanged - 0 fixed = 56 total (was 47)
-0 ⚠️ checkstyle 0m 24s tez-tools/analyzers/job-analyzer: The patch generated 1 new + 47 unchanged - 0 fixed = 48 total (was 47)
-0 ⚠️ checkstyle 0m 22s tez-tools/tez-tools-webapp: The patch generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0)
-0 ⚠️ checkstyle 0m 49s root: The patch generated 9 new + 55 unchanged - 0 fixed = 64 total (was 55)
+1 💚 hadolint 0m 1s There were no new hadolint issues.
+1 💚 markdownlint 0m 1s There were no new markdownlint issues.
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 7s The patch has no ill-formed XML file.
+1 💚 javadoc 3m 55s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 3m 24s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-1 ❌ findbugs 1m 8s tez-tools generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2)
-1 ❌ findbugs 5m 53s root generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2)
_ Other Tests _
+1 💚 unit 2m 38s tez-history-parser in the patch passed.
+1 💚 unit 2m 49s tez-tools in the patch passed.
+1 💚 unit 2m 48s job-analyzer in the patch passed.
+1 💚 unit 0m 30s tez-tools-webapp in the patch passed.
+1 💚 unit 75m 0s root in the patch passed.
-1 ❌ asflicense 2m 15s The patch generated 5 ASF License warnings.
163m 30s
Reason Tests
FindBugs module:tez-tools
Found reliance on default encoding in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String):in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String): new java.io.FileReader(String) At AnalyzerService.java:[line 158]
Inconsistent synchronization of org.apache.tez.tools.webapp.service.AnalyzerService.analyzers; locked 80% of time Unsynchronized access at AnalyzerService.java:80% of time Unsynchronized access at AnalyzerService.java:[line 81]
Possible null pointer dereference in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:[line 155]
org.apache.tez.tools.webapp.service.AnalyzerService.addFileToZip(File, ZipOutputStream) may fail to clean up java.io.InputStream on checked exception Obligation to clean up resource created at AnalyzerService.java:clean up java.io.InputStream on checked exception Obligation to clean up resource created at AnalyzerService.java:[line 199] is not discharged
FindBugs module:root
Found reliance on default encoding in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String):in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String): new java.io.FileReader(String) At AnalyzerService.java:[line 158]
Inconsistent synchronization of org.apache.tez.tools.webapp.service.AnalyzerService.analyzers; locked 80% of time Unsynchronized access at AnalyzerService.java:80% of time Unsynchronized access at AnalyzerService.java:[line 81]
Possible null pointer dereference in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:[line 155]
org.apache.tez.tools.webapp.service.AnalyzerService.addFileToZip(File, ZipOutputStream) may fail to clean up java.io.InputStream on checked exception Obligation to clean up resource created at AnalyzerService.java:clean up java.io.InputStream on checked exception Obligation to clean up resource created at AnalyzerService.java:[line 199] is not discharged
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/Dockerfile
GITHUB PR #139
JIRA Issue TEZ-4318
Optional Tests dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle hadolint shellcheck shelldocs markdownlint
uname Linux 7d6bca12fc98 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 3f541d0
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/diff-checkstyle-tez-tools.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/diff-checkstyle-tez-tools_analyzers_job-analyzer.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/diff-checkstyle-tez-tools_tez-tools-webapp.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/diff-checkstyle-root.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/new-findbugs-tez-tools.html
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/new-findbugs-root.html
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/testReport/
asflicense https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 2099 (vs. ulimit of 5500)
modules C: tez-plugins/tez-history-parser tez-tools tez-tools/analyzers/job-analyzer tez-tools/tez-tools-webapp . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.1 findbugs=3.0.1 hadolint=1.18.0-0-g76eee5c markdownlint=0.23.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apache apache deleted a comment from tez-yetus Aug 10, 2021
@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 12m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 5m 20s Maven dependency ordering for branch
+1 💚 mvninstall 8m 30s master passed
+1 💚 compile 3m 44s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 3m 32s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 2m 19s master passed
+1 💚 javadoc 3m 36s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 54s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗 spotbugs 0m 42s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 0m 46s tez-tools in master has 2 extant findbugs warnings.
+0 🆗 findbugs 5m 27s root in master has 2 extant findbugs warnings.
+0 🆗 findbugs 0m 39s tez-tools/analyzers/job-analyzer in master has 4 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 1m 59s Maven dependency ordering for patch
+1 💚 mvninstall 5m 51s the patch passed
+1 💚 compile 4m 26s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 4m 26s the patch passed
+1 💚 compile 4m 5s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 4m 5s the patch passed
-0 ⚠️ checkstyle 0m 25s tez-tools: The patch generated 7 new + 47 unchanged - 0 fixed = 54 total (was 47)
-0 ⚠️ checkstyle 0m 24s tez-tools/analyzers/job-analyzer: The patch generated 1 new + 47 unchanged - 0 fixed = 48 total (was 47)
-0 ⚠️ checkstyle 0m 22s tez-tools/tez-tools-webapp: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
-0 ⚠️ checkstyle 0m 49s root: The patch generated 7 new + 55 unchanged - 0 fixed = 62 total (was 55)
+1 💚 hadolint 0m 1s There were no new hadolint issues.
-1 ❌ markdownlint 0m 0s The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 7s The patch has no ill-formed XML file.
+1 💚 javadoc 3m 59s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 3m 25s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-1 ❌ findbugs 1m 8s tez-tools generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-1 ❌ findbugs 5m 51s root generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
_ Other Tests _
+1 💚 unit 2m 39s tez-history-parser in the patch passed.
+1 💚 unit 2m 50s tez-tools in the patch passed.
+1 💚 unit 2m 48s job-analyzer in the patch passed.
+1 💚 unit 0m 30s tez-tools-webapp in the patch passed.
+1 💚 unit 76m 21s root in the patch passed.
-1 ❌ asflicense 2m 15s The patch generated 1 ASF License warnings.
176m 1s
Reason Tests
FindBugs module:tez-tools
Possible null pointer dereference in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:[line 156]
FindBugs module:root
Possible null pointer dereference in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:[line 156]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/Dockerfile
GITHUB PR #139
JIRA Issue TEZ-4318
Optional Tests dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle hadolint shellcheck shelldocs markdownlint
uname Linux 5a84c9e43c66 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / fc63c04
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-checkstyle-tez-tools.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-checkstyle-tez-tools_analyzers_job-analyzer.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-checkstyle-tez-tools_tez-tools-webapp.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-checkstyle-root.txt
markdownlint https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-patch-markdownlint.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/new-findbugs-tez-tools.html
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/new-findbugs-root.html
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/testReport/
asflicense https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1463 (vs. ulimit of 5500)
modules C: tez-plugins/tez-history-parser tez-tools tez-tools/analyzers/job-analyzer tez-tools/tez-tools-webapp . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.1 findbugs=3.0.1 hadolint=1.18.0-0-g76eee5c markdownlint=0.23.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants