TEZ-4287: Upgrade FindBugs to SpotBugs

[belugabehr]

No description provided.

[belugabehr]

How do we update the build system to call out to this new spot bugs?

[abstractdog]

I think the error is because currently, we don't use a Jenkinsfile in the repo, but tez-multibranch job (link) has the --findbugs-strict-precheck flag, which is not handled then(once we'll have Jenkinsfile we can handle this in it). I believe I can remove that temporarily in the jenkins job configuration while having this tested, is it the proper way to do @jteagles ?

UPDATE: I commented out, could you retry @belugabehr ?

[jteagles]

There is a Jenkins file in progress as a PR submission that I haven't had time to verify. If anyone has time to try this out, it may help with better integration with Yetus.
https://github.com/aw-was-here/tez/commit/bead3a21e68ecf4a75d64d8c08b9f8fa0f98cf51

[abstractdog]

@jteagles : I was already looking at that patch, looks good, I'm about to adopt it piece-by-piece

[abstractdog]

@belugabehr, please rebase this PR as TEZ-4290 is merged, you might have minimal conflicts with that in Dockerfile

[hadoop-yetus]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-108/2/console in case of problems.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 0s	Docker failed to build yetus/tez:f88aa6f21.

Subsystem	Report/Notes
GITHUB PR	#108
JIRA Issue	TEZ-4287
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-108/2/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-108/3/console in case of problems.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	5m 56s	Maven dependency ordering for branch
+1 💚	mvninstall	7m 59s	master passed
+1 💚	compile	3m 50s	master passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	3m 30s	master passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javadoc	3m 46s	master passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	3m 14s	master passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 52s	the patch passed
+1 💚	compile	3m 52s	the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	3m 52s	the patch passed
+1 💚	compile	3m 30s	the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	3m 30s	the patch passed
+1 💚	hadolint	0m 2s	There were no new hadolint issues.
+1 💚	shellcheck	0m 4s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 5s	The patch has no ill-formed XML file.
+1 💚	javadoc	3m 41s	the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	3m 13s	the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
		_ Other Tests _
+1 💚	unit	2m 9s	tez-api in the patch passed.
+1 💚	unit	0m 46s	tez-runtime-internals in the patch passed.
+1 💚	unit	4m 26s	tez-dag in the patch passed.
+1 💚	unit	73m 30s	root in the patch passed.
+1 💚	asflicense	1m 56s	The patch does not generate ASF License warnings.
		134m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-108/3/artifact/out/Dockerfile
GITHUB PR	#108
JIRA Issue	TEZ-4287
Optional Tests	dupname asflicense hadolint shellcheck shelldocs javac javadoc unit xml compile
uname	Linux 3bfaccb2f61f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / 2fefe4a
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-108/3/testReport/
Max. process+thread count	1688 (vs. ulimit of 5500)
modules	C: tez-api tez-runtime-internals tez-dag . U: .
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-108/3/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.1 hadolint=1.18.0-0-g76eee5c
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[belugabehr]

@abstractdog Hey, can you please take a look at this PR once more? Thanks!

[abstractdog]

@belugabehr: could you please refresh/rebase this PR? considering that Jenkinsfile and github integration is working for a long time, we can retry this initiative

[maheshrajus]

Hi @belugabehr @mark-bathori
I am working for tez upgrade to jdk17. For this we need to replace findbugs with spotbugs.
I can see you both raised PR [https://github.com//pull/108] [https://github.com//pull/188] already and they are open from long back. Can i take it up and start working on it ?
Thanks !
cc: @abstractdog @ayushtkn

[belugabehr]

@maheshrajus , by all means. Thanks for picking this up.