fix(react-select): FilterBox focus event and adhoc filter popup height #9933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9933 +/- ##
==========================================
+ Coverage 71.30% 71.31% +0.01%
==========================================
Files 585 585
Lines 30872 30870 -2
Branches 3239 3236 -3
==========================================
+ Hits 22012 22015 +3
+ Misses 8751 8745 -6
- Partials 109 110 +1
Continue to review full report at Codecov.
|
ktmud
commented
May 27, 2020
| expect($node).to.have.length(9); | ||
| }); | ||
|
|
||
| cy.get('.chart-header').first().click({ force: true }); |
There was a problem hiding this comment.
This is for triggering blur on the filter select.
etr2460
reviewed
May 27, 2020
| // should open the filter indicator | ||
| cy.get('.filter-indicator.active') | ||
| .should('be.visible') | ||
| .should($node => { |
There was a problem hiding this comment.
why prefix node with a dollar sign? Can we get rid of that in the variable name?
There was a problem hiding this comment.
Was just following Cypress's official doc, but I agree it's probably not necessary.
| // should hide the filter indicator | ||
| cy.get('.filter-indicator') | ||
| .not('.active') | ||
| .should($node => { |
There was a problem hiding this comment.
same comment about the dollar sign here
etr2460
approved these changes
May 27, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
apache#9933) * fix(react-select): FilterBox focus event and adhoc filter popup height * Fix flacky cypress test * Use focus instead of click
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fixes two bugs related to recent migration of react-select.
Focusing on FilterBox select should open the filter indicators:
Select a lot of filter values in AdhocFilter editor should expand filter popup height.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See above.
TEST PLAN
Added a Cypress test case for the first bug.
ADDITIONAL INFORMATION