[line] growth vs factor option for 'Period Ratio' #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caravel/forms.py
Outdated
| 'period_ratio_type': (SelectField, { | ||
| "label": _("Period Ratio Type"), | ||
| "default": 'growth', | ||
| "choices": self.choicify(('factor', 'growth')), |
Member
Author
|
@xrmx good catch, I made the options translatable |
|
💯 🚢 |
| if num_period_compare: | ||
| num_period_compare = int(num_period_compare) | ||
| df = (df / df.shift(num_period_compare)) - 1 | ||
| prt = form_data.get('period_ratio_type') |
Member
There was a problem hiding this comment.
@mistercrunch
would it make sense to add tests to the viz.py functions?
Contributor
There was a problem hiding this comment.
It would be awesome to know that viz are rendering :)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.