Skip to content

Conversation

@mistercrunch
Copy link
Member

This makes MySQL, Sqlite and Postgres work with a special hard coded
rule. I'm hoping Alembic fixes the root cause eventually.

@bkyryliuk

This makes MySQL, Sqlite and Postgres work with a special hard coded
rule. I'm hoping Alembic fixes the root cause eventually.
@xrmx
Copy link
Contributor

xrmx commented Aug 17, 2016

Commit cite Postgresql but you are not doing anything specific for it.

@mistercrunch
Copy link
Member Author

Postgres was working with the current default setup. Though I might want to run the caravel db upgrade twice as part of the test to prevent a regression.

@bkyryliuk
Copy link
Member

bkyryliuk commented Aug 17, 2016

@mistercrunch
LGTM.
could you do a small thing, update the ./run_tests script to call db upgrade twice to ensure that it works ?

@mistercrunch
Copy link
Member Author

A'ight done, I referenced the new location of the DB as well ~/.caravel/

@mistercrunch mistercrunch merged commit 23a5463 into apache:master Aug 18, 2016
@mistercrunch mistercrunch deleted the test_migration branch August 18, 2016 00:10
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* feat: add dropGroupByControl

* control rename to DndColumnSelectControl

* add DND feature flag

* wip

* fix lint

* duplicate dnd control
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* feat: add dropGroupByControl

* control rename to DndColumnSelectControl

* add DND feature flag

* wip

* fix lint

* duplicate dnd control
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* feat: add dropGroupByControl

* control rename to DndColumnSelectControl

* add DND feature flag

* wip

* fix lint

* duplicate dnd control
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* feat: add dropGroupByControl

* control rename to DndColumnSelectControl

* add DND feature flag

* wip

* fix lint

* duplicate dnd control
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants