Skip to content

Conversation

@villebro
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Add geospatial post processing operations to new chart data endpoint.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

REVIEWERS

@codecov-io
Copy link

codecov-io commented Apr 27, 2020

Codecov Report

Merging #9661 into master will increase coverage by 6.51%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9661      +/-   ##
==========================================
+ Coverage   64.03%   70.54%   +6.51%     
==========================================
  Files         532      581      +49     
  Lines       28897    30272    +1375     
  Branches     2758     3072     +314     
==========================================
+ Hits        18503    21355    +2852     
+ Misses      10211     8805    -1406     
+ Partials      183      112      -71     
Flag Coverage Δ
#cypress 53.65% <ø> (-0.01%) ⬇️
#javascript 58.75% <ø> (?)
#python 70.63% <88.23%> (+0.06%) ⬆️
Impacted Files Coverage Δ
superset/utils/pandas_postprocessing.py 88.32% <83.78%> (-1.98%) ⬇️
superset/charts/schemas.py 100.00% <100.00%> (ø)
superset-frontend/src/setup/setupPlugins.ts 7.27% <0.00%> (-92.73%) ⬇️
superset/db_engine_specs/postgres.py 80.00% <0.00%> (-15.00%) ⬇️
superset-frontend/src/setup/setupApp.ts 24.13% <0.00%> (-2.79%) ⬇️
superset/db_engine_specs/mssql.py 93.02% <0.00%> (-1.10%) ⬇️
superset-frontend/src/featureFlags.ts 100.00% <0.00%> (ø)
superset-frontend/src/SqlLab/utils/sqlKeywords.ts 100.00% <0.00%> (ø)
...rontend/src/messageToasts/enhancers/withToasts.tsx 100.00% <0.00%> (ø)
...rset-frontend/src/components/StackTraceMessage.jsx
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4c291...186a1b2. Read the comment docs.

@villebro
Copy link
Member Author

@ktmud in reference to your comment on #9427 , I'll add the rename change here.

@villebro
Copy link
Member Author

@ktmud The change will require a slightly bigger refactor. I'll do this as a separate PR later to keep this PR simple. In the meantime you can do the select and rename by applying two consecutive selects; first renaming, next selecting. This will only cause negligible overhead, hence it might even be a better idea to split out all operations from select into separate operations to keep things simple: select_columns, drop_columns and rename_columns.

@villebro villebro requested a review from dpgaspar April 28, 2020 08:55
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of non blocking comments

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the test def name should be changed

@villebro
Copy link
Member Author

Thanks for the valuable comments @dpgaspar !

@villebro villebro requested a review from dpgaspar April 28, 2020 14:44
@villebro villebro merged commit a52cfcd into apache:master Apr 28, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 First shipped in 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.37.0 First shipped in 0.37.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants