Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade react-select and make multi-select sortable #9628

Merged
merged 10 commits into from
May 19, 2020
Merged

feat: upgrade react-select and make multi-select sortable #9628

merged 10 commits into from
May 19, 2020

Commits on May 19, 2020

  1. feat: upgrade react-select v1.3.0 to v3.1.0 

    Upgrade `react-select`, replace `react-virtualized-select` with a custom
solution implemented with `react-window`.

Future plans include deprecate `react-virtualized` used in other places, too.

Migrate all react-select related components to `src/Components/Select`.
    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    77fd828 View commit details
    Browse the repository at this point in the history

  2. Fix new list view

    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    b50484b View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    26498c2 View commit details
    Browse the repository at this point in the history

  4. Address PR comments

    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    00b6425 View commit details
    Browse the repository at this point in the history

  5. Fix a flacky Cypress test

    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    2e6f836 View commit details
    Browse the repository at this point in the history

  6. Adjust styles for Select in CRUD ListView

    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    77271f4 View commit details
    Browse the repository at this point in the history

  7. Fix loadOptions for owners select in chart PropertiesModal 

    TODO: add typing support for AsyncSelect props.
    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    7e25cb2 View commit details
    Browse the repository at this point in the history

  8. Address PR comments; allow isMulti in SelectControl, too

    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    761f6b6 View commit details
    Browse the repository at this point in the history

  9. Clean up NaN in table filter values

    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    3bfabac View commit details
    Browse the repository at this point in the history

  10. Fix flacky test

    @ktmud
    ktmud committed May 19, 2020
    Configuration menu
    Copy the full SHA
    5721a03 View commit details
    Browse the repository at this point in the history