fix: change number format to original value to "~g" #9608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
force-pushed
the
fix-number-formatter
branch
from
15f5b93 to
bf028c6
Compare
etr2460
reviewed
Apr 22, 2020
Member
There was a problem hiding this comment.
I'm not 100% convinced that ~f does the same thing as after reading the d3-format docs. Specifically i see this line:
The type
(none) is also supported as shorthand for~g(with a default precision of 12 instead of 6)
Should we use ~g instead of ~f here?
Member
Author
|
Oops, missed that in the document. But they seem to produce identical results, though:
|
Originally it uses " ", which do give the original value, but will not work when the `getNumberFormatter` in `superset-ui/number-format` is called for the second time. Because the format will successfully register as "" [1], but cannot be obtained again via `registry.get()`[2]. [1]: https://github.com/apache-superset/superset-ui/blob/44ad062dd02d080362dac28782c0327cc9fa3445/packages/superset-ui-number-format/src/NumberFormatterRegistry.ts#L30 [2]: https://github.com/apache-superset/superset-ui/blob/dc804b7a707e0cb8c29fc129bfff2c9aa143fd62/packages/superset-ui-core/src/models/RegistryWithDefaultKey.ts#L36
ktmud
force-pushed
the
fix-number-formatter
branch
from
bf028c6 to
3d33904
Compare
ktmud
changed the title
etr2460
approved these changes
Apr 22, 2020
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
hmm weird. thanks for making the change though!
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Apr 22, 2020
Originally it uses " ", which do give the original value, but will not work when the `getNumberFormatter` in `superset-ui/number-format` is called for the second time. Because the format will successfully register as "" [1], but cannot be obtained again via `registry.get()`[2]. [1]: https://github.com/apache-superset/superset-ui/blob/44ad062dd02d080362dac28782c0327cc9fa3445/packages/superset-ui-number-format/src/NumberFormatterRegistry.ts#L30 [2]: https://github.com/apache-superset/superset-ui/blob/dc804b7a707e0cb8c29fc129bfff2c9aa143fd62/packages/superset-ui-core/src/models/RegistryWithDefaultKey.ts#L36
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
#9562 adds number formatters for original value and integers. This PR changes number formatter for original value from
" "(a space character) to~g(decimal or exponential notation without trailing zeros). The original formatter" "is a valid d3 format and does return the original value as expected, but cannot be used as a registry key forsuperset-ui/number-format.This is because the registry automatically trims the registry key while creating a formatter, but when obtaining a formatter it returns
undefinedfor an empty string"".This is problematic when users changes the formatters back and forth in Explore view, resulting in JS errors.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@etr2460 @kristw @graceguo-supercat