[datesets] feat: add statsd to datasets api #9577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
changed the title
dpgaspar
reviewed
Apr 18, 2020
superset/datasets/api.py
Outdated
|
|
||
| @expose("/<pk>/refresh", methods=["PUT"]) | ||
| @protect() | ||
| @statsd_metrics |
Member
There was a problem hiding this comment.
Change the position, after the safe decorator
Codecov Report
@@ Coverage Diff @@
## master #9577 +/- ##
==========================================
+ Coverage 65.62% 70.47% +4.85%
==========================================
Files 574 574
Lines 30060 30081 +21
Branches 3054 3054
==========================================
+ Hits 19726 21199 +1473
+ Misses 10150 8771 -1379
+ Partials 184 111 -73
Continue to review full report at Codecov.
|
Member
|
Can you please fill the "Summary" to add a bit of context to this PR? |
dpgaspar
requested changes
Apr 21, 2020
Member
dpgaspar
left a comment
dpgaspar
left a comment
There was a problem hiding this comment.
Just missing 2 metric assertions
| def test_dataset_item_refresh_not_found(self): | ||
| """ | ||
| Dataset API: Test item refresh not found dataset | ||
| Dataset API: Test item refresh not found dataset |
Member
There was a problem hiding this comment.
Can we add the metric assert here?
| def test_dataset_item_refresh_not_owned(self): | ||
| """ | ||
| Dataset API: Test item refresh not owned dataset | ||
| Dataset API: Test item refresh not owned dataset |
Member
There was a problem hiding this comment.
Can we add the metric assert here?
lilykuang
force-pushed
the
lily/feature/statsd-table-api
branch
from
454b4f8 to
095e76c
Compare
etr2460
reviewed
Apr 22, 2020
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
Could you add a test plan to the PR as well? Thanks!
etr2460
approved these changes
Apr 23, 2020
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
cool, makes sense to me. thanks for the test plan!
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Adding statds metrics to datesets API endpoints (POST, PUT, DELETE, bulk_delete, data). This is an extension from #9519
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
superset.DatasetRestApi.[endpoints]overenvironment:sandboxADDITIONAL INFORMATION
REVIEWERS