(Reopened PR): Fix broken MultiLine chart #9505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@willbarrett seems like this one also died. Let's try to reopen a third time, and if that doesn't work we'll just have to wait until we have the new CI workflow in place. |
| "query": self.query, | ||
| "from_dttm": self.from_dttm, | ||
| "to_dttm": self.to_dttm, | ||
| "from_dttm": self.from_dttm if hasattr(self, "from_dttm") else None, |
Member
There was a problem hiding this comment.
NIT: I think it may be better to init self.from_dttm = None in the constructor of BaseViz, initializing all the attrs that may get assigned in the lifecycle of the object there
Member
Author
There was a problem hiding this comment.
Nit accepted. I need to close + reopen this PR again anyway because Travis won't play nice.
Member
Author
|
Closing as Travis failing to report status is unrecoverable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
See #9497
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@villebro @dpgaspar @craig-rueda