Skip to content

control to turn off table bar-chart backgrounds #9500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 6 commits into from
Apr 13, 2020
Merged

control to turn off table bar-chart backgrounds #9500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a40c70
control to turn off table bar-chart backgrounds
rusackas Apr 9, 2020
c6fc08e
flipping enable to disable, to support existing charts
rusackas Apr 10, 2020
0e82e75
lint :sparkles:
rusackas Apr 10, 2020
a3f2fba
Turn ON to enable (reversing logic)
rusackas Apr 11, 2020
37b8dee
bumping big number chart
rusackas Apr 13, 2020
da82242
ling :sparkles:
rusackas Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions superset-frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion superset-frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"@superset-ui/legacy-plugin-chart-treemap": "^0.11.15",
"@superset-ui/legacy-plugin-chart-word-cloud": "^0.11.15",
"@superset-ui/legacy-plugin-chart-world-map": "^0.11.15",
"@superset-ui/legacy-preset-chart-big-number": "^0.11.21",
"@superset-ui/legacy-preset-chart-big-number": "^0.12.13",
Copy link
Member Author

@rusackas rusackas Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to need a bump... not seeing any problems with it, but flagging it just in case.

Copy link
Member

@ktmud ktmud Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ^0.12.13 is probably identical to ^0.11.21. It was republished since moved into the superset-ui repo but the actual code doesn't really change (except the storybook).

"@superset-ui/legacy-preset-chart-deckgl": "^0.2.3",
"@superset-ui/legacy-preset-chart-nvd3": "^0.11.15",
"@superset-ui/number-format": "^0.12.10",
Expand Down
15 changes: 15 additions & 0 deletions superset-frontend/src/explore/controlPanels/Table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,21 @@ export default {
},
},
],
[
{
name: 'show_cell_bars',
config: {
type: 'CheckboxControl',
label: t('Show Cell Bars'),
renderTrigger: true,
default: true,
description: t(
'Enable to display bar chart background elements in table columns',
),
},
},
null,
],
],
},
],
Expand Down