Enable beautiful json for dashboard metadata editor#9482
Closed
ktmud wants to merge 1 commit intoapache:masterfrom
Closed
Enable beautiful json for dashboard metadata editor#9482ktmud wants to merge 1 commit intoapache:masterfrom
ktmud wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
welp.. looks like the job was received: https://travis-ci.org/github/apache/incubator-superset/builds/671939629?utm_medium=notification&utm_source=github_status but it hasn't notified github |
Closed
ktmud
force-pushed
the
dashboard-meta
branch
3 times, most recently
from
e2448ca to
747bc3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #9482 +/- ##
==========================================
- Coverage 58.76% 58.75% -0.02%
==========================================
Files 385 385
Lines 12237 12241 +4
Branches 3020 3020
==========================================
+ Hits 7191 7192 +1
- Misses 4862 4865 +3
Partials 184 184
Continue to review full report at Codecov.
|
This was referenced Apr 28, 2020
This was referenced Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try #9474 in a new branch to trigger CI.
CATEGORY
SUMMARY
Reformat JSON strings in the dashboard metadata modal input so it's easier to edit.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TEST PLAN
The JSON string in the code editor should be formatted.
ADDITIONAL INFORMATION
REVIEWERS
@graceguo-supercat @etr2460