fix(table-chart): bump legacy-table-chart to 0.11.18 #9275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
commented
Mar 11, 2020
| "abbrev": { | ||
| "version": "1.1.1", | ||
| "resolved": false, | ||
| "resolved": "", |
There was a problem hiding this comment.
Now the resolved is updated to empty string? Still a fresh npm ci though...
Codecov Report
@@ Coverage Diff @@
## master #9275 +/- ##
=======================================
Coverage 58.90% 58.90%
=======================================
Files 373 373
Lines 12026 12026
Branches 2953 2953
=======================================
Hits 7084 7084
Misses 4763 4763
Partials 179 179 Continue to review full report at Codecov.
|
etr2460
approved these changes
Mar 11, 2020
| "abbrev": { | ||
| "version": "1.1.1", | ||
| "resolved": false, | ||
| "resolved": "", |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
The new table chart implementation added in #9269 and #9234 throws a JS error when query results are empty but the metric list is not empty.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: there is a JS error when query results are empty for a table visualization with metrics:
After: it should show "no data available in table".
TEST PLAN
ADDITIONAL INFORMATION
N/A
REVIEWERS
cc: @etr2460 @kristw @graceguo-supercat