Skip to content

Conversation

@john-bodley
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR re-adds the FAB API endpoints to the SqlMetricInlineView and TableModelView view classes as currently Airbnb is using these to sync metadata. Note these were removed in #8960.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Tested locally and confirmed that the API endpoints were accessible.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @etr2460 @graceguo-supercat @michellethomas @mistercrunch

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #9035 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9035   +/-   ##
=======================================
  Coverage   59.43%   59.43%           
=======================================
  Files         369      369           
  Lines       11743    11743           
  Branches     2884     2884           
=======================================
  Hits         6980     6980           
  Misses       4584     4584           
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc60db2...72700aa. Read the comment docs.

@john-bodley john-bodley merged commit a267446 into apache:master Jan 28, 2020
@john-bodley john-bodley deleted the john-bodley--add-api-routes branch January 28, 2020 19:00
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jan 28, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 First shipped in 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0 First shipped in 0.36.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants