[SQL Lab] Cache function names query#9019
Merged
Merged
Conversation
john-bodley
approved these changes
Jan 24, 2020
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jan 25, 2020
(cherry picked from commit 922eec2)
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
As I tested this further, I realized that this was making a query to every presto and hive db whenever you open SQL Lab or open a new SQL Lab tab. This PR caches the result of the
show functionquery as we don't expect it to change often.TEST PLAN
Add a print statement to the function, see it the first time I open SQL Lab, but then when opening subsequent SQL Lab tabs, don't see the print statement again
ADDITIONAL INFORMATION
REVIEWERS
to: @john-bodley @villebro @betodealmeida