Skip to content

[dashboard] fix, enable info endpoint #9015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etr2460 merged 2 commits into from
Jan 25, 2020
Merged

[dashboard] fix, enable info endpoint #9015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5488e2
[dashboard] fix, enable info endpoint
nytai Jan 24, 2020
6a16f40
add info to REST_MODEL_VIEW_CRUD_SET
nytai Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class RouteMethod: # pylint: disable=too-few-public-methods
EDIT = "edit"
LIST = "list"
SHOW = "show"
INFO = "info"

# RestModelView specific
EXPORT = "export"
Expand All @@ -58,4 +59,4 @@ class RouteMethod: # pylint: disable=too-few-public-methods
# Commonly used sets
CRUD_SET = {ADD, LIST, EDIT, DELETE, ACTION_POST}
RELATED_VIEW_SET = {ADD, LIST, EDIT, DELETE}
REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT}
REST_MODEL_VIEW_CRUD_SET = {DELETE, GET, GET_LIST, POST, PUT, INFO}
Copy link
Member

@craig-rueda craig-rueda Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned with this pattern overall. Altering these "defaults" down the road could lead to unintended side effects.

Copy link
Member Author

@nytai nytai Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove it from the default and enable the info endpoint on a per-case basis. That was the original approach: a5488e2
but it seems like we'll need to info endpoint in most cases