-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] Enables swagger UI by default #8732
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8732 +/- ##
=======================================
Coverage 65.87% 65.87%
=======================================
Files 483 483
Lines 24123 24123
Branches 2767 2767
=======================================
Hits 15892 15892
Misses 8055 8055
Partials 176 176
Continue to review full report at Codecov.
|
I'm OK with this, given that it's behind a permission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding a row to the changelog would be appropriate, so nobody unknowingly exposes the swagger schema by mistake. Other than that (and the nit) LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; would still like a note in the changelog, but ok without it, too.
CATEGORY
SUMMARY
This is a proposal to enable FAB Swagger UI by default. To access the UI, user's need to have a specific permission
can show on SwaggerView
, if set by defaultsuperset init
will create the permission for swagger and associate it to theAdmin
role.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS