Skip to content

Comments

Fix more places where feature flags are serialized#8567

Merged
betodealmeida merged 1 commit intoapache:masterfrom
lyft:fix_more_ff_serialization
Nov 14, 2019
Merged

Fix more places where feature flags are serialized#8567
betodealmeida merged 1 commit intoapache:masterfrom
lyft:fix_more_ff_serialization

Conversation

@betodealmeida
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

#8529 fixed the serialization of the feature flags, but I missed a few places. I reviewed the code tree and fixed the serialization in the other places, updating unit tests accordingly.

TEST PLAN

Update unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@khtruong

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #8567 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8567      +/-   ##
=========================================
+ Coverage   66.75%   66.8%   +0.04%     
=========================================
  Files         450     450              
  Lines       22734   22734              
  Branches     2366    2366              
=========================================
+ Hits        15177   15187      +10     
+ Misses       7419    7409      -10     
  Partials      138     138
Impacted Files Coverage Δ
superset/views/core.py 72.05% <0%> (ø) ⬆️
superset/db_engine_specs/postgres.py 83.33% <0%> (+27.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59bc220...7d76d75. Read the comment docs.

@betodealmeida betodealmeida merged commit 78f41b3 into apache:master Nov 14, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 First shipped in 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.36.0 First shipped in 0.36.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants