Fix more places where feature flags are serialized#8567
Merged
betodealmeida merged 1 commit intoapache:masterfrom Nov 14, 2019
Merged
Fix more places where feature flags are serialized#8567betodealmeida merged 1 commit intoapache:masterfrom
betodealmeida merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8567 +/- ##
=========================================
+ Coverage 66.75% 66.8% +0.04%
=========================================
Files 450 450
Lines 22734 22734
Branches 2366 2366
=========================================
+ Hits 15177 15187 +10
+ Misses 7419 7409 -10
Partials 138 138
Continue to review full report at Codecov.
|
khtruong
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
#8529 fixed the serialization of the feature flags, but I missed a few places. I reviewed the code tree and fixed the serialization in the other places, updating unit tests accordingly.
TEST PLAN
Update unit tests.
ADDITIONAL INFORMATION
REVIEWERS
@khtruong