[WIP][dashboard scoped filter] part 2: add algorithm to convert checked ids to scope object#8559
Merged
graceguo-supercat merged 2 commits intoscope-selector-modal-v2from Nov 13, 2019
Conversation
graceguo-supercat
changed the title
Closed
12 tasks
kristw
reviewed
Nov 13, 2019
superset/assets/src/dashboard/util/getFilterScopeFromNodesTree.js
Outdated
Show resolved
Hide resolved
| return traverse({ | ||
| currentNode: nodes[0], | ||
| filterId: chartId, | ||
| checkedChartIds, |
Contributor
There was a problem hiding this comment.
can convert checkedChartIds to Set
Author
There was a problem hiding this comment.
checkedChartIds has no duplicates
superset/assets/src/dashboard/util/getFilterScopeFromNodesTree.js
Outdated
Show resolved
Hide resolved
superset/assets/src/dashboard/util/getFilterScopeFromNodesTree.js
Outdated
Show resolved
Hide resolved
superset/assets/src/dashboard/util/getFilterScopeFromNodesTree.js
Outdated
Show resolved
Hide resolved
superset/assets/src/dashboard/util/getFilterScopeFromNodesTree.js
Outdated
Show resolved
Hide resolved
kristw
approved these changes
Nov 13, 2019
Codecov Report
@@ Coverage Diff @@
## scope-selector-modal-v2 #8559 +/- ##
==========================================================
+ Coverage 65.93% 66% +0.06%
==========================================================
Files 469 470 +1
Lines 23085 23127 +42
Branches 2468 2485 +17
==========================================================
+ Hits 15222 15265 +43
+ Misses 7702 7701 -1
Partials 161 161
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is #8521 rebased on latest master.
REVIEWERS
@willbarrett @kristw @etr2460