[cli] Fix, import datasources exported by UI

[dpgaspar]

CATEGORY

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

Databases/Datasources export on the UI can't be imported by superset import_datasource cli.
This fix makes UI yaml export for SQLAlchemy datasources and Druid compatible with the cli.

ADDITIONAL INFORMATION

• Has associated issue: Databases export/import yaml file bug #8453
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

@villebro

[codecov-io]

Codecov Report

Merging #8477 into master will increase coverage by 0.27%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8477      +/-   ##
==========================================
+ Coverage   66.52%   66.79%   +0.27%     
==========================================
  Files         449      449              
  Lines       22595    22701     +106     
  Branches     2367     2366       -1     
==========================================
+ Hits        15032    15164     +132     
+ Misses       7425     7399      -26     
  Partials      138      138

Impacted Files	Coverage Δ
superset/connectors/druid/views.py	69.33% <ø> (+0.41%)	⬆️
superset/utils/import_datasource.py	100% <ø> (ø)	⬆️
superset/views/base.py	72.54% <100%> (+1.9%)	⬆️
superset/views/database/views.py	92.23% <100%> (+8.71%)	⬆️
.../explore/components/controls/DatasourceControl.jsx	67.74% <0%> (-1.01%)	⬇️
superset/db_engine_specs/base.py	80.33% <0%> (-0.4%)	⬇️
.../explore/components/controls/DateFilterControl.jsx	39.62% <0%> (-0.38%)	⬇️
.../assets/src/SqlLab/components/TabbedSqlEditors.jsx	83.03% <0%> (-0.3%)	⬇️
superset/views/core.py	71.96% <0%> (-0.19%)	⬇️
superset/connectors/sqla/models.py	84.81% <0%> (-0.12%)	⬇️
... and 20 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3b121...69cd2d2. Read the comment docs.

[villebro]

I think this should be fixed in the UI export, as currently the UI and CLI are generating different yamls.

[dpgaspar]

I think this should be fixed in the UI export, as currently the UI and CLI are generating different yamls.

Right, but YamlExportMixin is used in a bunch of ModelView's. So some options:

• We go with this solution
• Implement a new mixin something like YamlExportDatabaseMixin
• implement the export right on the DatabaseModelView

It's also a decision between: all UI yaml, export the same data structure or database yaml export and cli export/import use same data structure

[villebro]

I'm ok with this as a temporary solution if others are ok with it. Perhaps add the infamous TODO: to make sure it gets promptly fixed once someone finds the time? 😄

[villebro]

Small nit, other than that LGTM

[villebro]

nit: ..if you want a dict response..