Skip to content

Comments

introduce a space in command line option#8438

Merged
mistercrunch merged 1 commit intoapache:masterfrom
christophlingg:patch-2
Oct 24, 2019
Merged

introduce a space in command line option#8438
mistercrunch merged 1 commit intoapache:masterfrom
christophlingg:patch-2

Conversation

@christophlingg
Copy link
Contributor

see https://docs.celeryproject.org/en/latest/userguide/optimizing.html
Bildschirmfoto 2019-10-24 um 10 58 06

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

According to the examples in the docs, there need to be a space between -O and fair. However, this notation still seems to be supported as I found examples in the web. Probably still cleaner to stick closely to the celery docs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #8438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8438   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files         448      448           
  Lines       22486    22486           
  Branches     2364     2364           
=======================================
  Hits        15204    15204           
  Misses       7144     7144           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786d770...2dbb104. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mistercrunch mistercrunch merged commit 1d5718a into apache:master Oct 24, 2019
@dpgaspar dpgaspar added the v0.35 label Dec 20, 2019
@mistercrunch mistercrunch added 🍒 0.35.2 Cherry-picked to 0.35.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 First shipped in 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.35 🍒 0.35.2 Cherry-picked to 0.35.2 🚢 0.36.0 First shipped in 0.36.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants