[fix] Updating parse_human_timedelta typing#8436
Merged
john-bodley merged 1 commit intoapache:masterfrom Oct 23, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8436 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 448 448
Lines 22486 22486
Branches 2364 2364
=======================================
Hits 15204 15204
Misses 7144 7144
Partials 138 138
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Oct 23, 2019
michellethomas
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Oct 24, 2019
(cherry picked from commit 786d770)
dpgaspar
pushed a commit
that referenced
this pull request
Oct 28, 2019
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 13, 2019
mistercrunch
added
🍒 0.35.0
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR fixes a regression introduced in #8409 as per the typing for
parse_human_timedeltaI was led to believe thatsneeded to be astryet it was being passed a type ofOptional[str]. The logic I added inQueryObjectturned out to be wrong as in factswas of typeOptional[str]per: https://github.com/apache/incubator-superset/blob/9fc37ea9f1ff032dea923012613d4e7189ada178/superset/utils/core.py#L303TEST PLAN
Added additional unit test.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @graceguo-supercat @michellethomas @mistercrunch