docs: Add an 'Orientation' section to CONTRIBUTING.md#8422
Merged
mistercrunch merged 1 commit intoapache:masterfrom Oct 23, 2019
Merged
docs: Add an 'Orientation' section to CONTRIBUTING.md#8422mistercrunch merged 1 commit intoapache:masterfrom
mistercrunch merged 1 commit intoapache:masterfrom
Conversation
etr2460
approved these changes
Oct 22, 2019
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
lgtm.
I think there's probably some future work to clean up CONTRIBUTING.md or refactor it into multiple smaller files since it's getting a bit large and overwhelming, but that doesn't block this
mistercrunch
force-pushed
the
orientation
branch
from
ef95c11 to
a09b458
Compare
Codecov Report
@@ Coverage Diff @@
## master #8422 +/- ##
==========================================
- Coverage 67.61% 67.59% -0.03%
==========================================
Files 448 448
Lines 22486 22486
Branches 2364 2364
==========================================
- Hits 15204 15199 -5
- Misses 7144 7149 +5
Partials 138 138
Continue to review full report at Codecov.
|
Member
Author
|
Agreed on CONTRIBUTING it has become kind of crazy. This new orientation section was really lacking though. |
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 13, 2019
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
docs: Add an 'Orientation' section to CONTRIBUTING.md