[fix] refine release instructions#8381
[fix] refine release instructions#8381villebro merged 7 commits intoapache:masterfrom villebro:villebro-release-0.34.1
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8381 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 448 448
Lines 22486 22486
Branches 2364 2364
=======================================
Hits 15204 15204
Misses 7144 7144
Partials 138 138Continue to review full report at Codecov.
|
RELEASING/README.md
Outdated
There was a problem hiding this comment.
maybe (First Time Only) as opposed to one-off? Not sure if that's clearer...
RELEASING/README.md
Outdated
There was a problem hiding this comment.
not in scope for this review, but I feel like we should prefix these env vars with SUPERSET (e.g. SUPERSET_VERSION and SUPERSET_RC) since they could easily conflict with something else in the user's terminal session.
|
@etr2460 @dpgaspar @mistercrunch this should now be good to go; did a dry run and everything checked out. Beyond the changes proposed by @etr2460 I also added a rename step to remove RC from the filenames upon final release which was previously missing. Will proceed to work on the email scripts next if nobody else beats me to it. |
villebro
changed the title
RELEASING/README.md
Outdated
There was a problem hiding this comment.
oh, gotta push that to the apache remote here too
# push the branch
git push apache {branch}
# push the tag
git push apache {tag}In the one-off setup, we may want to have an instruction to create the remote for apache:
git remote add apache git@github.com:apache/incubator-superset.git
There was a problem hiding this comment.
Perhaps leave those to #8432 ? This is already pretty crowded, perhaps best to get this out of the way now if there's nothing that can't wait until the next PR?
|
As there seems to be three PRs dealing with release instructions, I'm going to take the liberty of merging this and deferring any remaining changes to the other two PRs. |
* Separate RC from VERSION * Fix pypi_push.sh and refine instructions * Add SUPERSET_ prefix to env variables * Finalize release instructions * Change one-off to First Time Only * Add tagging of final version * Convert some remaining env variables and add a check step to pypi deploy
mistercrunch
added
🏷️ bot
4 participants
CATEGORY
Choose one
SUMMARY
During the
0.34.1release process, I came across a few errors or imperfections in the release instructions. These are addressed in this PR.