[docs] CTAS on PostgreSQL needs commit to apply

[dpgaspar]

CATEGORY

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

#8362 CREATE TABLE AS... on PostgreSQL needs a commit to apply (transactional DDL).
This means that the engine parameters need to have AUTOCOMMIT so that SQLLab CTAS can work. This is a simple PR to document this exception

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue: CTAS executed but resulting table not created #8362
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

@mistercrunch @villebro

[villebro]

I think adding the option under Database would be a unintrusive way of fixing this, having it right under "Allow DML" along with a clear and concise description.

[dpgaspar]

Update on the issue (Thanks: @rc-ontruck), this can be simply solved by using:

{
"metadata_params": {},
"engine_params": {"isolation_level":"AUTOCOMMIT"},
"metadata_cache_timeout": {},
"schemas_allowed_for_csv_upload": []
}

This checks my second option, that I think it's less intrusive. Going to update docs to refer to this

[codecov-io]

Codecov Report

Merging #8367 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8367      +/-   ##
==========================================
+ Coverage   67.57%   67.65%   +0.07%     
==========================================
  Files         448      448              
  Lines       22527    22498      -29     
  Branches     2364     2364              
==========================================
- Hits        15222    15220       -2     
+ Misses       7167     7140      -27     
  Partials      138      138

Impacted Files	Coverage Δ
superset/connectors/druid/models.py	82.41% <0%> (ø)	⬆️
superset/views/core.py	71.45% <0%> (+1.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7ea3d...5974027. Read the comment docs.

[villebro]

Perhaps clarify by explicitly mentioning that CTAS require DML + split up into two sentences to make it easier on the eyes.

[villebro]

My bad; I somehow assumed this was being done as DML, not using the button! The text above sounds good. Not sure if this is overkill, but it might be a good idea to also mention this under docs/installation.rst where database-specific quirks are listed, or at least a reference from one to the other.

[dpgaspar]

no problem, I would say that a small note is not overkill. Just updated it

[dpgaspar]

^^ @villebro