[tests] Fix, removing deprecated function for future Python release compatibility.#8353
Merged
dpgaspar merged 2 commits intoapache:masterfrom Oct 21, 2019
Conversation
Member
|
Extra info on this: https://docs.python.org/3/library/unittest.html#deprecated-aliases @MarcusSorealheis while your at it, can I ask you to change |
Codecov Report
@@ Coverage Diff @@
## master #8353 +/- ##
=======================================
Coverage 67.57% 67.57%
=======================================
Files 448 448
Lines 22529 22529
Branches 2363 2363
=======================================
Hits 15223 15223
Misses 7168 7168
Partials 138 138Continue to review full report at Codecov.
|
Contributor
Author
|
thanks @dpgaspar |
Contributor
Author
|
@dpgaspar does this LGTM? |
Contributor
Author
|
here is where CI failed (which is unrelated to the change): |
mistercrunch
approved these changes
Oct 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Here, I replaced all the occurrences of
assertEqualswithassertEqualin the test files in anticipation of its removal in future Python releases. The alias has been deprecated for sometime.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
run tests.
ADDITIONAL INFORMATION
REVIEWERS
@betodealmeida or someone else that works on tests.