-
Notifications
You must be signed in to change notification settings - Fork 16.1k
#[Visualisation]:Added Grid Gallery as custom visualisation #8346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added react-grid-gallery visualization
…ddition info about product on image hover
added react-grid-gallery visualization
…ddition info about product on image hover
|
In general, I think we're trying to get away from adding visualizations to the main superset repo, instead splitting them out into plugins. You can see examples of that here: https://github.com/apache-superset/superset-ui-plugins I would recommend not relying on the @kristw would have more context on this as well |
|
I agree with all @etr2460 said above. With that said, I would like to clarify here that we probably won't merge this PR. Superset is a large community now. Adding one uncommon type of visualization into the main repo, which will show up in everybody's deployment, is not a scalable direction. Please create a plugin and you can plug that into your personal deployment. |
|
I am also agreed with you @kristw but when we can get final cut of add custom vis in so that we can follow steps and deploy custom vis in our personal deployment. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
CATEGORY
Grid Gallery is a custom visualisation added in superset to solve use cases like showing table with images with description and addition information like trending e-commerce websites are showing their menu items.
This component is based on of https://github.com/benhowell/react-grid-gallery.
Any suggestions/Feedback are welcome to improve in this component .
Choose one
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS