Skip to content

Conversation

@jitendra-kumawat
Copy link
Contributor

@jitendra-kumawat jitendra-kumawat commented Oct 4, 2019

CATEGORY

Grid Gallery is a custom visualisation added in superset to solve use cases like showing table with images with description and addition information like trending e-commerce websites are showing their menu items.

This component is based on of https://github.com/benhowell/react-grid-gallery.

Any suggestions/Feedback are welcome to improve in this component .

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2019-10-04 at 5 57 37 PM

Screenshot 2019-10-04 at 5 56 17 PM

Screenshot 2019-10-04 at 5 57 13 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

jitendra-kumawat and others added 17 commits June 18, 2018 15:47
added react-grid-gallery  visualization
added react-grid-gallery  visualization
@etr2460
Copy link
Member

etr2460 commented Oct 4, 2019

In general, I think we're trying to get away from adding visualizations to the main superset repo, instead splitting them out into plugins. You can see examples of that here: https://github.com/apache-superset/superset-ui-plugins

I would recommend not relying on the viz.py file and instead use the new /api/v1/query/ endpoint to interface with superset for this visualizations. You can fork this template repo and add your new plugin here, then use it in your instance of superset https://github.com/apache-superset/superset-ui-plugins-template

@kristw would have more context on this as well

@kristw
Copy link
Contributor

kristw commented Oct 18, 2019

I agree with all @etr2460 said above. With that said, I would like to clarify here that we probably won't merge this PR. Superset is a large community now. Adding one uncommon type of visualization into the main repo, which will show up in everybody's deployment, is not a scalable direction. Please create a plugin and you can plug that into your personal deployment.

@jitendra-kumawat
Copy link
Contributor Author

I am also agreed with you @kristw but when we can get final cut of add custom vis in
https://github.com/apache-superset/superset-ui-plugins

so that we can follow steps and deploy custom vis in our personal deployment.

@stale
Copy link

stale bot commented Dec 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Dec 20, 2019
@stale stale bot closed this Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inactive Inactive for >= 30 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants