Move from MVC FAB menu to Superset React menu #8289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
force-pushed
the
tai/react-menu
branch
4 times, most recently
from
952aff4 to
617a3f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #8289 +/- ##
==========================================
- Coverage 66.75% 65.69% -1.07%
==========================================
Files 450 479 +29
Lines 22734 23641 +907
Branches 2366 2587 +221
==========================================
+ Hits 15177 15530 +353
- Misses 7419 7942 +523
- Partials 138 169 +31
Continue to review full report at Codecov.
|
kristw
reviewed
Oct 3, 2019
kristw
reviewed
Oct 3, 2019
mistercrunch
requested changes
Oct 5, 2019
mistercrunch
changed the title
Member
|
Should we go straight to do this on all templates? Progressive rollout per page? |
Member
Author
|
@mistercrunch I was hoping for either a progressive rollout or a followup pr to replace the menu in all views. I'd like to avoid bloating this PR with a ton of files changed. Additionally if anything breaks in the new code the bug footprint will be limited to a single view. Also, happy to do a full replace in this pr if you think that would be a better approach. |
nytai
force-pushed
the
tai/react-menu
branch
from
088407b to
50b54bb
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
dependent on: dpgaspar/Flask-AppBuilder#1116
Adds a new react menu component to the
welcomeview. The menu should be exactly the same as the one rendered by FAB.The react menu can be added to other pages by overriding the navbar block and rendering nothing, then adding the menu component in the react layout.
TEST PLAN
the welcome view renders the same menu as any other view
ADDITIONAL INFORMATION
REVIEWERS