chore: fix flaky SQL Lab test with .focus().blur()#8215
Closed
mistercrunch wants to merge 2 commits intoapache:masterfrom
Closed
chore: fix flaky SQL Lab test with .focus().blur()#8215mistercrunch wants to merge 2 commits intoapache:masterfrom
mistercrunch wants to merge 2 commits intoapache:masterfrom
Conversation
Member
|
Great! and looks good on travis, let's hope it works |
Member
|
I think the problem here is that the select all on the textbox is failing. The travis logs show running a query like: |
12 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Second attempt at fixing the flaky cypress SQL Lab test. My intuition is that
.focus().blur()is needed to insure that the store gets updated. With redux getting save to local storage onChange, it takes some millisecs to save that payload, so we prevent updating the store as it makes typing SQL laggy, and only commit to the store on blur.Guessing there's a timing issue where blur may not occur in time, so trying to be explicit about it. For reference, other tests were doing this more explicitly before, so extending the approach to all tests touching Ace editor.
🤞 🤞 🤞
@dpgaspar