Skip to content

adding spaces missing from string concatenations#8126

Merged
mistercrunch merged 1 commit intoapache:masterfrom
preset-io:missing-spaces-in-strings
Aug 27, 2019
Merged

adding spaces missing from string concatenations#8126
mistercrunch merged 1 commit intoapache:masterfrom
preset-io:missing-spaces-in-strings

Conversation

@rusackas
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Just a couple of missing spaces from string concatenations that cropped up.

@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #8126 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8126   +/-   ##
=======================================
  Coverage   65.89%   65.89%           
=======================================
  Files         485      485           
  Lines       22933    22933           
  Branches     2538     2538           
=======================================
  Hits        15111    15111           
  Misses       7690     7690           
  Partials      132      132
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 42.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1269c3...e0200c3. Read the comment docs.

@mistercrunch mistercrunch merged commit 2085e89 into apache:master Aug 27, 2019
@mistercrunch mistercrunch deleted the missing-spaces-in-strings branch August 27, 2019 17:37
@villebro villebro added the v0.34 label Sep 8, 2019
@rusackas rusackas restored the missing-spaces-in-strings branch September 9, 2019 23:27
@rusackas rusackas deleted the missing-spaces-in-strings branch December 4, 2019 18:45
@rusackas
Copy link
Member Author

rusackas commented Dec 4, 2019

🏷 preset-io

@mistercrunch mistercrunch added 🍒 0.34.1 Cherry-picked to 0.34.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 First shipped in 0.35.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.34 🍒 0.34.1 Cherry-picked to 0.34.1 🚢 0.35.0 First shipped in 0.35.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants