Skip to content

removed database deps from reqs-dev.txt and typo.#8111

Merged
mistercrunch merged 2 commits intoapache:masterfrom
MarcusSorealheis:rempve_database_depdenceies
Aug 26, 2019
Merged

removed database deps from reqs-dev.txt and typo.#8111
mistercrunch merged 2 commits intoapache:masterfrom
MarcusSorealheis:rempve_database_depdenceies

Conversation

@MarcusSorealheis
Copy link
Contributor

@MarcusSorealheis MarcusSorealheis commented Aug 25, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@MarcusSorealheis
Copy link
Contributor Author

setting up dev should be similar to setting up other tiers.

@MarcusSorealheis
Copy link
Contributor Author

The test fails because pyhive isn't installed. I need to update tests.

@MarcusSorealheis
Copy link
Contributor Author

Changing the scope here to address typo and deps issue in separate repos

@codecov-io
Copy link

Codecov Report

Merging #8111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8111   +/-   ##
=======================================
  Coverage   65.89%   65.89%           
=======================================
  Files         485      485           
  Lines       22917    22917           
  Branches     2537     2537           
=======================================
  Hits        15102    15102           
  Misses       7683     7683           
  Partials      132      132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac1a29...0a709ec. Read the comment docs.

@mistercrunch mistercrunch merged commit b1269c3 into apache:master Aug 26, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 First shipped in 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.35.0 First shipped in 0.35.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants